Skip to content

rk3399 (Pinebook pro) EDP support

Alper Nebi Yasak u-boot 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 of 10 patches 0 repliesNew
  2. v14 of 8 patches 0 repliesSuperseded

8 of 10 patches are in this archive. The cover letter announces 10.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode+0 -00 replies
2/10drivers/video/rockchip/rk_edp.c: Add rk3399 support+0 -00 replies
3/10drivers/video/rockchip/rk_edp.c: Change interrupt polarity configuration+0 -00 replies
4/10drivers/video/rockchip/rk_vop.c: Reserve efi fb memory+0 -00 replies
7/10drivers/pwm/rk_pwm.c: Fix default polarity+0 -00 replies
8/10drivers/video/rockchip/rk_vop.c: Fix format of fbbase in debug string+0 -00 replies
9/10drivers/video/rockchip/rk_edp.c: Add missing reset support+0 -00 replies
10/10drivers/video/rockchip/rk_vop.c: Add reset support+0 -00 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchAlper Nebi Yasak
1/10T-b
2/10T-b
3/10T-b
4/10T-b
7/10T-b
8/10T-b
9/10T-b
10/10T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [patch v2 00/10] rk3399 (Pinebook pro) EDP support
Quoted 8 lines · Arnaud Patard (Rtp)

This patchset add support for the rk3399 eDP. It has been tested on the pinebook pro and Google Kevin chromeos devices.

The changes have been written by studying the linux code, since I didn't find any manual for theses part of the RK3399 SoC.

For Kevin devices, this patchset is needed:
https://patchwork.ozlabs.org/project/uboot/list/?series=209553

(Arnaud's patchset does not depend on any of mine, they are AFAIK independently applicable)

That series is not enough though -- gru-kevin isn't even upstream. Here's my git branch I tested (with success) on it including ugly hacks and patches not sent/sendable to the mailing lists yet:

https://github.com/alpernebbi/u-boot/commits/rk3399-gru-kevin/wip

Here's another branch that I'm keeping up-to-date for gru-bob with analogous changes, but I cannot test it myself:

    https://github.com/alpernebbi/u-boot/commits/rk3399-gru-bob-edp/wip

Those contain this version of this series now, and should make this series testable by people having one of the two chromebooks.

Quoted 11 lines

On the linux kernel side, on recent kernels, it needs commit "pwm: rockchip: Keep enabled PWMs running while probing" otherwise the pinebook pro will freeze when probing the display.

Changes since v2:
- Add reset support for the VOP and eDP. This was needed and it appears to also solve the issue with warm reset.
- Fix a debug string in the vop driver
- Drop the patch "drivers/video/rockchip/rk_edp.c: Change clock rate".
- Address various comments