skbuff: introduce pskb_realloc_headroom()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | skbuff: introduce pskb_realloc_headroom()include/ net/ | +43 | 72 replies | |
| 2/7 | ipv6: use pskb_realloc_headroom in ip6_finish_output2net/ | +16 | 0 replies | |
| 3/7 | ipv6: use pskb_realloc_headroom in ip6_xmit refactoringnet/ | +12 | 0 replies | |
| 4/7 | ipv4: use pskb_realloc_headroom in ip_finish_output2net/ | +2 | 0 replies | |
| 5/7 | vrf: use pskb_realloc_headroom in vrf_finish_outputdrivers/ | +4 | 0 replies | |
| 6/7 | ax25: use pskb_realloc_headroomnet/ net/ | +8 | 0 replies | |
| 7/7 | bpf: use pskb_realloc_headroom in bpf_out_neigh_v4/6net/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH NET 0/7] skbuff: introduce pskb_realloc_headroom()
currently if skb does not have enough headroom skb_realloc_headrom is called. It is not optimal because it creates new skb.
Unlike skb_realloc_headroom, new helper pskb_realloc_headroom does not allocate a new skb if possible;
copies skb->sk on new skb when as needed
and frees original skb in case of failures.
This helps to simplify ip[6]_finish_output2(), ip6_xmit() and a few other functions in vrf, ax25 and bpf.
There are few other cases where this helper can be used but they require an additional investigations.
NB: patch "ipv6: use pskb_realloc_headroom in ip6_finish_output2" depends on patch "ipv6: allocate enough headroom in ip6_finish_output2()" submitted separately
https://lkml.org/lkml/2021/7/12/732
Vasily Averin (7):
skbuff: introduce pskb_realloc_headroom()
ipv6: use pskb_realloc_headroom in ip6_finish_output2
ipv6: use pskb_realloc_headroom in ip6_xmit
ipv4: use pskb_realloc_headroom in ip_finish_output2
vrf: use pskb_realloc_headroom in vrf_finish_output
ax25: use pskb_realloc_headroom
bpf: use pskb_realloc_headroom in bpf_out_neigh_v4/6
drivers/net/vrf.c | 14 +++------ include/linux/skbuff.h | 2 ++ net/ax25/ax25_out.c | 13 +++------ net/ax25/ax25_route.c | 13 +++------ net/core/filter.c | 22 +++----------- net/core/skbuff.c | 41 ++++++++++++++++++++++++++ net/ipv4/ip_output.c | 12 ++------ net/ipv6/ip6_output.c | 78 ++++++++++++++++++-------------------------------- 8 files changed, 89 insertions(+), 106 deletions(-)
Signature · 1 line
1.8.3.1