Samsung PWM support cleanup
Get series with b4
b4 am '0ab601ce867e$90b95770$b22c0650$@org'Versions newest first
- v4 Latest0 of 20 patches 0 repliesNew
Patches in v4 No applies recorded yet
None of the 20 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Thierry Reding |
|---|---|
| Series | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/20] Samsung PWM support cleanup
Quoted 33 lines · Kukjin Kim
Quoted 9 lines · Tomasz Figa
Quoted 7 lines · On Monday 22 of July 2013 00:22:16 Sylwester Nawrocki wrote:
Quoted 6 lines · Tomasz Figa
Since we now have a proper Samsung PWM clocksource driver in place, we can proceed with further cleanup of PWM timers support on Samsung SoCs.>
This series attempts to achieve this goal by:
1) fixing up few things insamsung_pwm_timerclocksource driver,
2) moving remaining Samsung platforms to the new clocksourcedriver,
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
3) removing old clocksource driver,
4) adding new multiplatform- and DT-aware PWM driver,
5) moving all Samsung platforms to use the new PWM driver,
6) removing old PWM driver,
7) removing all PWM-related code that is not used anymore.Cleaning up the PWM driver is a bit tricky, because the design of current driver makes it completely unsuitable for DT and multiplatform and would require a heavy rework to make it usable, breaking any existing Samsung PWM users by the way. To avoid any breakage this series first renames the old driver, then adds new one using original name, migrates all platforms to use it and then finally removes the old driver.
See particular patches for more detailed descriptions.
[On S3C6410-based Tiny6410 (Mini6410-compatible) with pwm-beeper, SMDK6410 with PWM backlight and Exynos4210-based Origen board (with PWM0 attached to a scope)]
Tested-by Tomasz Figa<[email protected]>
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
[On S3C2440-based Mini2440 board]Tested-by Sylwester Nawrocki<[email protected]>I have retested this series on top of v3.11-rc1 with pwm-backlight
(and
Quoted 3 lines
Quoted 3 lines
buzzer
as the output :)) on Mini2440. It seems to work well - generated frequencies are correct. I'll check pulse widths with a scope
tomorrow,
Quoted 11 lines
Quoted 7 lines
Quoted 4 lines
as it's a bit late
now. FWIW you can add to this series my:Reviewed-by Sylwester Nawrocki <[email protected]>Thanks. I hope we can finally get this series merged soon.
Yes, this whole patches look good to me, and I'd like to take this whole patches into the samsung tree...but need to get any response from PWM guy, Thierry Reding. Let's wait for his response...
To be clarify, because his ack was on v3 and I remember he had a comment. So would be better if we could get his ack on pwm change again.
Thanks,
Kukjin