Skip to content

/dev/random: Assorted fixes and cleanups

Matt Mackall lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22/dev/random: Simplify entropy debuggingdrivers/char/random.c+10 -370 replies
2/22/dev/random: Cleanup sleep logicdrivers/char/random.c+11 -122 replies
3/22/dev/random: remove broken resizing sysctldrivers/char/random.c include/linux/sysctl.h+3 -862 replies
4/22/dev/random: remove outdated RNDGETPOOL ioctldrivers/char/random.c include/linux/compat_ioctl.h include/linux/random.h+3 -431 reply
5/22/dev/random: pool struct cleanup and renamedrivers/char/random.c+56 -620 replies
6/22/dev/random: simplify pool initializationdrivers/char/random.c+35 -510 replies
7/22/dev/random: simplify reseed logicdrivers/char/random.c+6 -140 replies
8/22/dev/random: BUG on premature random usersdrivers/char/random.c+2 -70 replies
9/22/dev/random: more robust catastrophic reseed logicdrivers/char/random.c+23 -150 replies
10/22/dev/random: entropy reserve logic for starvation prevedrivers/char/random.c+17 -130 replies
11/22/dev/random: flag pools that need entropy reservedrivers/char/random.c+3 -10 replies
12/22/dev/random: add pool for /dev/urandom to prevent starvdrivers/char/random.c+17 -150 replies
13/22/dev/random: kill extract_timer_statedrivers/char/random.c+0 -30 replies
14/22/dev/random: kill unused md5 copydrivers/char/random.c+12 -1480 replies
15/22/dev/random: kill unrolled SHA codedrivers/char/random.c+0 -1463 replies
16/22/dev/random: kill 2.2 cruftdrivers/char/random.c+0 -100 replies
17/22/dev/random: minor shrinkagedrivers/char/random.c+12 -140 replies
18/22/dev/random: bitop cleanupdrivers/char/random.c+1 -410 replies
19/22/dev/random: use sched_clock for timing datadrivers/char/random.c+9 -120 replies
20/22/dev/random: cleanup rol bitopdrivers/char/random.c+7 -330 replies
21/22/dev/random: kill batching of entropy mixingdrivers/char/random.c include/linux/random.h+19 -1332 replies
22/22/dev/random: update creditsdrivers/char/random.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/22] /dev/random: Assorted fixes and cleanups

This is a collection of fixes and cleanups for the Linux /dev/random driver including:

- more robust/correct entropy accounting and reseed logic
- starvation avoidance for simultaneous /dev/random and /dev/urandom users
- remove entropy batching
- wakeup bug fix
- remove various legacy code
- remove i386isms

I've broken this into a bunch of very simple bits, so I'm afraid the patch count is rather high by non-gregkh standards.

These patches have been tested by various people since pre-2.6.0 and have been in my -tiny tree since its inception. Andrew, please queue these in -mm for wider testing/review.