Skip to content

ethtool: runtime-resume netdev parent before ethtool ops

Heiner Kallweit linux-pm netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 16 repliesApplied 4/4

Patches in v1 All 4 applied

#Subject and filesSizeRepliesApplied
1/4ethtool: runtime-resume netdev parent before ethtool ioctl opsnet/ethtool/ioctl.c+15 -39 repliesApplied
2/4ethtool: move implementation of ethnl_ops_begin/complete to netlink.cnet/ethtool/netlink.c net/ethtool/netlink.h+16 -130 repliesApplied
3/4ethtool: move netif_device_present check from ethnl_parse_header_dev_get to ethnl_ops_beginnet/ethtool/netlink.c+7 -70 repliesApplied
4/4ethtool: runtime-resume netdev parent in ethnl_ops_beginnet/ethtool/netlink.c+25 -62 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/4] ethtool: runtime-resume netdev parent before ethtool ops

If a network device is runtime-suspended then:
- network device may be flagged as detached and all ethtool ops (even if not accessing the device) will fail because netif_device_present() returns false
- ethtool ops may fail because device is not accessible (e.g. because being in D3 in case of a PCI device)

It may not be desirable that userspace can't use even simple ethtool ops that not access the device if interface or link is down. To be more friendly to userspace let's ensure that device is runtime-resumed when executing ethtool ops in kernel.

This patch series covers the typical case that the netdev parent is power- managed, e.g. a PCI device. Not sure whether cases exist where the netdev itself is power-managed. If yes then we may need an extension for this. But the series as-is at least shouldn't cause problems in that case.

Heiner Kallweit (4):
ethtool: runtime-resume netdev parent before ethtool ioctl ops
ethtool: move implementation of ethnl_ops_begin/complete to netlink.c
ethtool: move netif_device_present check from
ethnl_parse_header_dev_get to ethnl_ops_begin
ethtool: runtime-resume netdev parent in ethnl_ops_begin

 net/ethtool/ioctl.c   | 18 ++++++++++++++---
 net/ethtool/netlink.c | 45 +++++++++++++++++++++++++++++++++++++------
 net/ethtool/netlink.h | 15 ++-------------
 3 files changed, 56 insertions(+), 22 deletions(-)
Signature · 1 line
2.32.0