Skip to content

bnx2: Misc fixes

Michael Chan netdev 1 version In review

Get series with b4
b4 am 1116892439.4908.1.camel@rh4

Versions newest first

  1. v1 Latest6 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6bnx2: Fix excessive stack usagedrivers/net/bnx2.c+24 -74 replies
2/6bnx2: Fix rx checksumdrivers/net/bnx2.c+1 -20 replies
3/6bnx2: Fix excessive udelaydrivers/net/bnx2.c+10 -240 replies
4/6bnx2: Fix bug in bnx2_closedrivers/net/bnx2.c+2 -10 replies
5/6bnx2: Add bnx2 prefix and mark staticdrivers/net/bnx2.c drivers/net/bnx2_fw.h+169 -1690 replies
6/6bnx2: Update revision and reldatedrivers/net/bnx2.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] bnx2: Misc fixes

These patches fix the following problems spotted by Jeff Garzik. Thanks Jeff.

Quoted 9 lines

8) excessive stack size in bnx2_alloc_bad_rbuf():

13) [additional review] why is CHECKSUM_UNNECESSARY used when cksum==0xffff or cksum==0 ?

15) the following loop is just silly. use mdelay or (preferably) msleep.

19) [additional review] need flush_scheduled_work(), if using work

queues?

Quoted 1 line

21) need to call bnx2_netif_stop() in bnx2_close()