Skip to content

acxsm: Make acxsm modular again (2nd try)

Carlos Martin netdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 of 7 patches 0 repliesNew

4 of 7 patches are in this archive. The cover letter announces 7.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7acxsm: Change Kconfig and Makefile to be modularKconfig Makefile+31 -240 replies
2/7acxsm: Move module init/exit to the modulescommon.c pci.c usb.c+21 -550 replies
3/7acxsm: Create struct acx_opsacx_struct.h+28 -40 replies
6/7acxsm: Assign chip-specific ops in the probe functionsacx_func.h pci.c usb.c+44 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] acxsm: Make acxsm modular again (2nd try)

Hi,

There are a couple of differences between this and my previos patch, so I'll list them here:

- Separate the patches properly

- This patchset uses the default generic functions and calls the appropiate function using a #define, which should be much clearer and saves us from having to migrate the whole common.c file.

- We get the proper string for the _debug family of functions.

- acx_ops.issue_cmd takes different functions depending on the debug level so we save a few bytes we weren't going to use otherwise. This also saves a function call.

- Denis' sense of style has been applied, though some of it doesn't apply anymore and some came from me trying to do too many things at once which screwed up the format. I hope these are alright.

 Kconfig      |   40 ++++++++++----------
 Makefile     |   15 +++++--
 acx_func.h   |  112 ++++++++++++++++++++--------------------------------------
 acx_struct.h |   32 ++++++++++++++--
 common.c     |  113 ++++++++++++++++++++++++++++-------------------------------
 ioctl.c      |    2 +
 pci.c        |   31 ++++++++++++++++
 usb.c        |   27 +++++++++++++-
 8 files changed, 212 insertions(+), 160 deletions(-)

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642