Skip to content

aic94xx: sas code clean-up

Alexis Bruemmer linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8aic94xx: move sas READMEDocumentation/scsi/sas.txt drivers/scsi/sas/README+3 -4840 replies
2/8aic94xx: remove the sas_common.c filedrivers/scsi/sas/Makefile drivers/scsi/sas/sas_common.c drivers/scsi/sas/sas_init.c+25 -1160 replies
3/8aic94xx: remove the //depot SCM commentsdrivers/scsi/sas/Kconfig drivers/scsi/sas/Makefile drivers/scsi/sas/sas_discover.c +17 more+0 -220 replies
4/8aic94xx: remove expander_conf.cdrivers/scsi/sas/Makefile drivers/scsi/sas/expander_conf.c+0 -4651 reply
5/8aic94xx: remove inline functionsdrivers/scsi/sas/sas_discover.c drivers/scsi/sas/sas_expander.c drivers/scsi/sas/sas_scsi_host.c +1 more+38 -350 replies
6/8aic94xx: move list_each_entry_reverse_safe from sas_discover.h to list.hinclude/linux/list.h include/scsi/sas/sas_discover.h+6 -72 replies
7/8aic94xx: remove queue implementation commentdrivers/scsi/sas/sas_event.c+0 -401 reply
8/8aic94xx: use bitops for testing, setting and clearing bitsdrivers/scsi/sas/sas_internal.h include/scsi/sas/sas_class.h+13 -111 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] aic94xx: sas code clean-up

These patches were created in response to the comments from this earlier email:
http://marc.theaimsgroup.com/?l=linux-scsi&m=114624643916659&w=2

First off, thank you Christoph for your comments. I am working to address them, starting with the ones that are easiest to implement. Follows is a set of patches that address the following concerns:

1) Move the sas readme to the Documents dir-- this still needs to be written so that it 'matches reality', but I want to merge the sas*.h files to libsas.h and sas.h first
2) Remove the sas_common.c file
3) Remove the //depot SCM comments
4) Remove the expander_conf.c from the kernel tree
5) Remove various inline functions
6) Move list_each_entry_reverse_safe from sas_discover.h to list.h
7) Remove the long queue implementation comment
8) Use bitops for setting and clearing bits

These patches are just a start and I will continue to address these issues.

Regards,

Alexis