Skip to content

remove set_wmb

Steven Rostedt linux-arch lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2remove set_wmb - doc updateDocumentation/memory-barriers.txt+2 -32 replies
2/2remove set_wmb - arch removalinclude/asm-alpha/barrier.h include/asm-arm/system.h include/asm-arm26/system.h +20 more+1 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/02] remove set_wmb

set_wmb(var, value) is not used anywhere in the kernel. And it doesn't do anything special but shorten the typing of:

  var = value;
  wmb();

Which the above is much more readable, and thus set_wmb is just something to confuse developers even more.

So this patch series removes set_wmb from the kernel. It's not currently used in the kernel, and any out-of-kernel branch can easily replace it. So there should be no harm in removing it.

The first patch removes it from Documentation/memory-barriers.txt and the second patch does a sweep through all the architectures to get rid of it. All archs do the above code except ia64 and sparc which do a mb() instead. But regardless, it's still not used.

-- Steve