Skip to content

blk request timeout handler: mv scsi timer code to block layer

Mike Christie linux-scsi lkml 1 version In review

Get series with b4
b4 am 1153820377.4166.22.camel@max

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2blk request timeout handler: add blk layer helpersblock/ll_rw_blk.c include/linux/blkdev.h+159 -110 replies
2/2blk request timeout handler:drivers/scsi/aacraid/aachba.c drivers/scsi/advansys.c drivers/scsi/gdth.c +21 more+84 -2570 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] blk request timeout handler

Sorry if this is a duplicate, I had some trouble with my mailer in the middle if sending the patches.

The following patches move the scsi command timeout code from the scsi layer to the block layer. I originally did them so request based multipath could reuse the code, but the code can be used by anyone so I thought I should send it seperately.

I have tested the normal and error paths with iscsi and am in the middle of testing the libata error paths. The latter needs more care since it is the only strategy handler user. I have also converted all the timeout_per_command users but some of the LLDs still need a "#include blkdev.h".

So the patches are not ready for mergingm but I wanted to get feedback on the scsi timer code and if it was accpetable or was it not so nice? And I wanted to see if these patches were ok alone or if all the scsi eh needed to be moved at the same time. These patches do not move the quiesce, abort or reset code.