Skip to content

Fix bugs in udev_rules_apply_format()

Sergey Vlasov linux-hotplug 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3udev_rules_apply_format(): fix handling of unknown formatudev_rules.c+4 -00 replies
2/3udev_rules_apply_format(): don't overflow the buffer whenudev_rules.c+1 -13 replies
3/3udev_rules_apply_format(): do not process substitutedudev_rules.c+1 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Fix bugs in udev_rules_apply_format()

Hello!

Here are fixes for several bugs in udev_rules_apply_format():

1) fix handling of unknown format elements
2) don't overflow the buffer when truncating substituted string
3) do not process substituted value as format string

Without these fixes (especially the last one) udev behaves strangely when substituting some values (due to reinterpretation of the substituted string as a format string, which may then abuse the first two bugs). The problem may be triggered, e.g., by attaching an USB storage device with a label containing '$' or '%' characters.

Combined diffstat of all patches:

 udev_rules.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

If you prefer, you may pull these changes from the following git repo and branch (based on release 104):

git://git.altlinux.org/people/vsu/packages/udev.git alt-format-fixes

(also available over http: and rsync:, but not really useful due to packing).

Signature · 11 lines
Sergey Vlasov

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel