RFC : Composite Devices Support
Get series with b4
b4 am 1170431215.23028.45.camel@balbiVersions newest first
- v1 RFC Latest5 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | : Composite Devices Supportdrivers/ include/ | +0 | 0 replies | |
| 2/5 | : Composite Devices Supportdrivers/ | +0 | 0 replies | |
| 3/5 | : Composite Devices Support | +0 | 0 replies | |
| 4/5 | : Composite Devices Support | +0 | 0 replies | |
| 5/5 | : Composite Devices Support | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC] [PATCH 0/5]: Composite Devices Support
The following patch series add support for Composite Devices following what was proposed David Brownell's patch.
Each patch modify one g_* module (ether, file_storage, serial) and another one sets up the base for such support.
We have some known issues but the code is working pretty fine with omap_h3 and omap_h2 development boards.
We still have some work to do but this is our approach for USB Composite Gadgets support. If you could please comment the idea, we would be able to refine the code.
Listed below are the know issues:
- How to get which are the implemented bRequestTypes, as defined on linux as the USB_TYPE_ macros, from the gadget drivers?
- Some of the direct attributions will be turned up into proper functions.
- One of the patches modify omap_udc.c to add 3 more endpoints for us to be able to test composite framework running with all of the g_* gadget drivers.
- A composite Gadget with only one function, wouldn't it become a simple gadget? If this is true, wouldn't be better to modify USB Gadget Framework to become USB Gadget/Composite Framework and get rid of those #if defined's?
- omap_udc.c defines some fifo_modes. The way it is implemented composite framework would be limited to the fifo_modes omap_udc.c implements, I mean that whenever I add a new gadget driver, we would need to implement another fifo_mode to handle the endpoints. Wouldn't be nice to make the fifo_modes more dynamic ??
Signature · 9 lines
Best Regards, Felipe Balbi [email protected] Nokia Institute of Technology - INdT Kernel Developers Team +55 92 2126 1003