Skip to content

Clean up signal code [take #3]

Franck Bui-Huu linux-mips 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10signals: reduce {setup,restore}_sigcontext sizesarch/mips/kernel/signal-common.h+21 -450 replies
2/10signal: do not inline functions in signal-common.harch/mips/kernel/signal-common.h arch/mips/kernel/signal.c+153 -1360 replies
3/10signal: clean up sigframe structurearch/mips/kernel/signal-common.h arch/mips/kernel/signal.c arch/mips/kernel/signal32.c +1 more+81 -690 replies
4/10signal32: remove code duplicationarch/mips/kernel/signal32.c+4 -460 replies
5/10signal: test return value of install_sigtramp()arch/mips/kernel/signal.c+3 -30 replies
6/10signal: factorize debug codearch/mips/kernel/signal-common.h arch/mips/kernel/signal.c arch/mips/kernel/signal32.c +1 more+21 -240 replies
7/10signal32: reduce {setup,restore}_sigcontext32 sizesarch/mips/kernel/signal32.c+97 -1140 replies
8/10signal32: no need to save c0_status register in setup_sigcontext32()arch/mips/kernel/signal32.c+0 -10 replies
9/10signal: do not use save_static_function() anymorearch/mips/kernel/signal.c arch/mips/kernel/signal32.c arch/mips/kernel/signal_n32.c+10 -306 replies
10/10signal: do not inline handle_signal()arch/mips/kernel/signal.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/10] Clean up signal code [take #3]

Hi Ralf,

Here is the third version of this patchset.
I ran (on a 32-bits kernel _only_) all LTP signal testcases and they all passed. I haven't time to look at what these tests exactly do though.

Changes from take #2:
---------------------
- Do not use save_static_function() anymore
- do not inline handle_signal()

Changes from take #1:
---------------------
- Fix ICACHE_REFILLS_WORKAROUND_WAR usages
- Do not save/restore cp0_status register anymore
- Check impact on performances

Please, consider.

Franck

---
 arch/mips/kernel/signal-common.h |  194 +++++-----------------
 arch/mips/kernel/signal.c        |  231 +++++++++++++++++++-------
 arch/mips/kernel/signal32.c      |  341 +++++++++++++++-----------------------
 arch/mips/kernel/signal_n32.c    |   34 ++--
 4 files changed, 361 insertions(+), 439 deletions(-)