Skip to content

RFC timer_stats slimmed down

Martin Peschke linux-s390 lkml 1 version In review

Get series with b4
b4 am 1176545387.5462.108.camel@dix

Versions newest first

  1. v1 RFC Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4timer_stats slimmed down: statistics prereq, cleanupinclude/linux/statistic.h lib/statistic.c+4 -40 replies
2/4timer_stats slimmed down: statistics prereq, labelsinclude/linux/statistic.h lib/statistic.c+53 -200 replies
3/4timer_stats slimmed down: statistics prereq, keysinclude/linux/statistic.h lib/statistic.c+272 -510 replies
4/4timer_stats slimmed down: using statistics infrastucturekernel/time/timer_stats.c kernel/timer.c+59 -3280 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC] [Patch 0/4] timer_stats slimmed down

2.6.21-rc* kernels come with a feature that adds timer statistics to /proc/timer_stats (CONFIG_TIMER_STATS). This patch set makes it use the proposed statistics infrastructure (-mm tree), and adds prequisite functions to the statistics code.

The result are noticeable lines of code savings. kernel/time/timer_stats.c which comes with several functions which can be made redundant by using corresponding functions of lib/statistic.c, that is:

- accounting
- printing output in sequential files
- user interface for switching accounting on/off, reset etc.
- measuring the accounting time
- per-cpu optimisations

Function that were missing in lib/statistics, and which are added by this patch set, are:

- allow arbitrary keys for statistics entries (e.g. structures)
- allow client to label output of statistics entries (e.g. using keys)

A secondary effect of the patch set is that we won't add another entry to good old /proc. The statistics infrastructure uses debugfs.

This patch set is a prototype that works for me, but which might allow for optimisations. Suggestions are welcome.

[Patch 1/4] timer_stats slimmed down: statistics prereq, cleanup [Patch 2/4] timer_stats slimmed down: statistics prereq, labels [Patch 3/4] timer_stats slimmed down: statistics prereq, keys [Patch 4/4] timer_stats slimmed down: using statistics infrastucture

Patch set is against 2.6.21-rc6-mm1 and additionaly requires "[Patch] statistics: fix sorted list" posted this morning.