Skip to content

phy/gianfar: Fixes for gianfar and vitesse RGMII-ID support

Andy Fleming linuxppc-dev netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4phy: Fix Vitesse 824x PHY interrupt ackingdrivers/net/phy/vitesse.c+21 -20 replies
2/4gianfar: Add phy-connection-type to gianfar nodesDocumentation/powerpc/booting-without-of.txt arch/powerpc/boot/dts/mpc8641_hpcn.dts+10 -00 replies
3/4phy: Fix Vitesse RGMII-ID supportdrivers/net/phy/vitesse.c+20 -30 replies
4/4gianfar: Fix RGMII-ID handling in gianfararch/powerpc/sysdev/fsl_soc.c drivers/net/gianfar.c include/linux/fsl_devices.h+21 -10 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchHaiying Wang
1/4A-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 2.6.22-rc7 0/4] phy/gianfar: Fixes for gianfar and vitesse RGMII-ID support

A few bugs in the Vitesse PHY driver were found on the 8641D HPCN board. Originally, they were masked by a bug in the PHY Lib which was fixed by patch 5f708dd91d15876e26d7a57f97a255cedffca463 (Fix phy_id for Vitesse 824x PHY). That patch allowed the Vitesse PHY to bind on the 8641D HPCN board, thereby exposing a bug in the interrupt handling and a bug in the configuration of the PHY. This sequence of patches fixes the irq handling bug, then fixes the configuration bug in 3 places:

1) The Vitesse PHY driver
2) The gianfar driver (needs to pass in the mode correctly for internal delay)
3) The OF device tree for arch/powerpc boards

You can apply the following patches, or pull them directly:

The following changes since commit c5e3ae8823693b260ce1f217adca8add1bc0b3de:
Ayaz Abdulla (1):
forcedeth bug fix: realtek phy

are found in the git repository at:

http://opensource.freescale.com/pub/scm/linux-2.6-85xx.git netdev

Andy Fleming (4):
Fix Vitesse 824x PHY interrupt acking
Add phy-connection-type to gianfar nodes
Fix Vitesse RGMII-ID support
Fix RGMII-ID handling in gianfar

 Documentation/powerpc/booting-without-of.txt |    6 +++
 arch/powerpc/boot/dts/mpc8641_hpcn.dts       |    4 ++
 arch/powerpc/sysdev/fsl_soc.c                |    9 +++++
 drivers/net/gianfar.c                        |   12 ++++++-
 drivers/net/phy/vitesse.c                    |   46 +++++++++++++++++++++++---
 include/linux/fsl_devices.h                  |    1 +
 6 files changed, 72 insertions(+), 6 deletions(-)