Skip to content

desc_struct integration

Glauber de Oliveira Costa lkml virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19unify desc_structarch/x86/kernel/apm_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/process_64.c +3 more+38 -2910 replies
1/19unify desc_structarch/x86/kernel/apm_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/process_64.c +4 more+45 -310 replies
1/19unify desc_structarch/x86/kernel/apm_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/process_64.c +4 more+45 -310 replies
1/19unify desc_structarch/x86/kernel/apm_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/process_64.c +4 more+45 -310 replies
1/19unify desc_structarch/x86/kernel/apm_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/process_64.c +4 more+45 -310 replies
1/19unify desc_structarch/x86/kernel/apm_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/process_64.c +4 more+45 -310 replies
2/19unify struct desc_ptrarch/x86/kernel/asm-offsets_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/doublefault_32.c +11 more+38 -450 replies
2/19unify struct desc_ptrarch/x86/kernel/asm-offsets_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/doublefault_32.c +11 more+38 -450 replies
2/19unify struct desc_ptrarch/x86/kernel/asm-offsets_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/doublefault_32.c +11 more+38 -450 replies
2/19unify struct desc_ptrarch/x86/kernel/asm-offsets_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/doublefault_32.c +11 more+38 -450 replies
2/19unify struct desc_ptrarch/x86/kernel/asm-offsets_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/doublefault_32.c +11 more+38 -450 replies
2/19unify struct desc_ptrarch/x86/kernel/asm-offsets_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/doublefault_32.c +11 more+38 -450 replies
2/19unify struct desc_ptrarch/x86/kernel/asm-offsets_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/doublefault_32.c +11 more+38 -450 replies
2/19unify struct desc_ptrarch/x86/kernel/asm-offsets_32.c arch/x86/kernel/cpu/common.c arch/x86/kernel/doublefault_32.c +11 more+38 -450 replies
3/19change gdt acessor macro namearch/x86/kernel/setup64.c arch/x86/kernel/suspend_64.c arch/x86/kernel/vsyscall_64.c +1 more+8 -80 replies
3/19change gdt acessor macro namearch/x86/kernel/setup64.c arch/x86/kernel/suspend_64.c arch/x86/kernel/vsyscall_64.c +1 more+8 -80 replies
3/19change gdt acessor macro namearch/x86/kernel/setup64.c arch/x86/kernel/suspend_64.c arch/x86/kernel/vsyscall_64.c +1 more+8 -80 replies
3/19change gdt acessor macro namearch/x86/kernel/setup64.c arch/x86/kernel/suspend_64.c arch/x86/kernel/vsyscall_64.c +1 more+8 -80 replies
3/19change gdt acessor macro namearch/x86/kernel/setup64.c arch/x86/kernel/suspend_64.c arch/x86/kernel/vsyscall_64.c +1 more+8 -80 replies
3/19change gdt acessor macro namearch/x86/kernel/setup64.c arch/x86/kernel/suspend_64.c arch/x86/kernel/vsyscall_64.c +1 more+8 -80 replies
3/19change gdt acessor macro namearch/x86/kernel/setup64.c arch/x86/kernel/suspend_64.c arch/x86/kernel/vsyscall_64.c +1 more+8 -80 replies
4/19removed unused variableinclude/asm-x86/desc_64.h+0 -50 replies
4/19removed unused variableinclude/asm-x86/desc_64.h+0 -50 replies
4/19removed unused variableinclude/asm-x86/desc_64.h+0 -50 replies
4/19removed unused variableinclude/asm-x86/desc_64.h+0 -50 replies
4/19removed unused variableinclude/asm-x86/desc_64.h+0 -50 replies
4/19removed unused variableinclude/asm-x86/desc_64.h+0 -50 replies
4/19removed unused variableinclude/asm-x86/desc_64.h+0 -50 replies
5/19introduce gate_desc type.arch/x86/kernel/traps_32.c include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+19 -110 replies
5/19introduce gate_desc type.arch/x86/kernel/traps_32.c include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+19 -110 replies
5/19introduce gate_desc type.arch/x86/kernel/traps_32.c include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+19 -120 replies
5/19introduce gate_desc type.arch/x86/kernel/traps_32.c include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+19 -120 replies
5/19introduce gate_desc type.arch/x86/kernel/traps_32.c include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+19 -120 replies
5/19introduce gate_desc type.arch/x86/kernel/traps_32.c include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+19 -120 replies
5/19introduce gate_desc type.arch/x86/kernel/traps_32.c include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+19 -120 replies
6/19change write_idt_entry signaturearch/x86/kernel/paravirt_32.c arch/x86/xen/enlighten.c include/asm-x86/desc_32.h +1 more+15 -100 replies
6/19change write_idt_entry signaturearch/x86/kernel/paravirt_32.c arch/x86/xen/enlighten.c include/asm-x86/desc_32.h +1 more+15 -100 replies
6/19change write_idt_entry signaturearch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c arch/x86/lguest/boot.c +3 more+32 -160 replies
6/19change write_idt_entry signaturearch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c arch/x86/lguest/boot.c +3 more+32 -160 replies
6/19change write_idt_entry signaturearch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c arch/x86/lguest/boot.c +3 more+32 -160 replies
6/19change write_idt_entry signaturearch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c arch/x86/lguest/boot.c +3 more+32 -160 replies
6/19change write_idt_entry signaturearch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c arch/x86/lguest/boot.c +3 more+32 -160 replies
6/19change write_idt_entry signaturearch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c arch/x86/lguest/boot.c +3 more+32 -160 replies
7/19introduce ldt_desc type.include/asm-x86/desc_64.h include/asm-x86/desc_defs.h+4 -20 replies
7/19introduce ldt_desc type.include/asm-x86/desc_64.h include/asm-x86/desc_defs.h+4 -20 replies
7/19introduce ldt_desc type.include/asm-x86/desc_64.h include/asm-x86/desc_defs.h+4 -20 replies
7/19introduce ldt_desc type.include/asm-x86/desc_64.h include/asm-x86/desc_defs.h+4 -20 replies
7/19introduce ldt_desc type.include/asm-x86/desc_64.h include/asm-x86/desc_defs.h+4 -20 replies
7/19introduce ldt_desc type.include/asm-x86/desc_64.h include/asm-x86/desc_defs.h+4 -20 replies
7/19introduce ldt_desc type.include/asm-x86/desc_64.h include/asm-x86/desc_defs.h+4 -20 replies
8/19modify write_ldt functionarch/x86/kernel/ldt.c+7 -80 replies
8/19modify write_ldt functionarch/x86/kernel/ldt.c+7 -80 replies
8/19modify write_ldt functionarch/x86/kernel/ldt.c+7 -80 replies
8/19modify write_ldt functionarch/x86/kernel/ldt.c+7 -80 replies
8/19modify write_ldt functionarch/x86/kernel/ldt.c+7 -80 replies
8/19modify write_ldt functionarch/x86/kernel/ldt.c+7 -80 replies
8/19modify write_ldt functionarch/x86/kernel/ldt.c+7 -80 replies
8/19modify write_ldt functionarch/x86/kernel/ldt.c+7 -80 replies
9/19introduce fill_ldtarch/x86/kernel/ldt.c arch/x86/kernel/process_64.c arch/x86/kernel/tls.c +3 more+24 -400 replies
9/19introduce fill_ldtarch/x86/kernel/ldt.c arch/x86/kernel/process_64.c arch/x86/kernel/tls.c +3 more+24 -400 replies
9/19introduce fill_ldtarch/x86/kernel/ldt.c arch/x86/kernel/process_64.c arch/x86/kernel/tls.c +3 more+24 -400 replies
9/19introduce fill_ldtarch/x86/kernel/ldt.c arch/x86/kernel/process_64.c arch/x86/kernel/tls.c +3 more+24 -401 reply
9/19introduce fill_ldtarch/x86/kernel/ldt.c arch/x86/kernel/process_64.c arch/x86/kernel/tls.c +3 more+34 -400 replies
9/19introduce fill_ldtarch/x86/kernel/ldt.c arch/x86/kernel/process_64.c arch/x86/kernel/tls.c +3 more+34 -400 replies
9/19introduce fill_ldtarch/x86/kernel/ldt.c arch/x86/kernel/process_64.c arch/x86/kernel/tls.c +3 more+34 -400 replies
10/19change write_gdt_entry signature.arch/x86/kernel/paravirt_32.c arch/x86/kernel/smpcommon_32.c arch/x86/xen/enlighten.c +2 more+29 -250 replies
10/19change write_gdt_entry signature.arch/x86/kernel/paravirt_32.c arch/x86/kernel/smpcommon_32.c arch/x86/xen/enlighten.c +2 more+29 -250 replies
10/19provide tss_descinclude/asm-x86/desc_defs.h+2 -00 replies
10/19provide tss_descinclude/asm-x86/desc_defs.h+2 -00 replies
10/19provide tss_descinclude/asm-x86/desc_defs.h+2 -00 replies
10/19provide tss_descinclude/asm-x86/desc_defs.h+2 -00 replies
10/19provide tss_descinclude/asm-x86/desc_defs.h+2 -00 replies
11/19change write_ldt_entry signaturearch/x86/kernel/ldt.c arch/x86/xen/enlighten.c include/asm-x86/desc_32.h +2 more+19 -140 replies
11/19change write_ldt_entry signaturearch/x86/kernel/ldt.c arch/x86/xen/enlighten.c include/asm-x86/desc_32.h +2 more+19 -140 replies
11/19change write_gdt_entry signature.arch/x86/kernel/paravirt_32.c arch/x86/kernel/smpcommon_32.c arch/x86/kernel/vmi_32.c +4 more+56 -340 replies
11/19change write_gdt_entry signature.arch/x86/kernel/paravirt_32.c arch/x86/kernel/smpcommon_32.c arch/x86/kernel/vmi_32.c +4 more+56 -340 replies
11/19change write_gdt_entry signature.arch/x86/kernel/paravirt_32.c arch/x86/kernel/smpcommon_32.c arch/x86/kernel/vmi_32.c +4 more+56 -340 replies
11/19change write_gdt_entry signature.arch/x86/kernel/paravirt_32.c arch/x86/kernel/smpcommon_32.c arch/x86/kernel/vmi_32.c +4 more+56 -340 replies
11/19change write_gdt_entry signature.arch/x86/kernel/paravirt_32.c arch/x86/kernel/smpcommon_32.c arch/x86/kernel/vmi_32.c +4 more+56 -340 replies
12/19move constants to desc_defs.hinclude/asm-x86/desc_32.h include/asm-x86/desc_defs.h+7 -80 replies
12/19move constants to desc_defs.hinclude/asm-x86/desc_32.h include/asm-x86/desc_defs.h+7 -80 replies
12/19change write_ldt_entry signaturearch/x86/kernel/ldt.c arch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c +4 more+30 -160 replies
12/19change write_ldt_entry signaturearch/x86/kernel/ldt.c arch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c +4 more+30 -160 replies
12/19change write_ldt_entry signaturearch/x86/kernel/ldt.c arch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c +4 more+30 -160 replies
12/19change write_ldt_entry signaturearch/x86/kernel/ldt.c arch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c +4 more+30 -160 replies
12/19change write_ldt_entry signaturearch/x86/kernel/ldt.c arch/x86/kernel/paravirt_32.c arch/x86/kernel/vmi_32.c +4 more+30 -160 replies
13/19unify non-paravirt parts of desc.hinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+99 -1220 replies
13/19unify non-paravirt parts of desc.hinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+99 -1220 replies
13/19move constants to desc_defs.hinclude/asm-x86/desc_32.h include/asm-x86/desc_defs.h+5 -80 replies
13/19move constants to desc_defs.hinclude/asm-x86/desc_32.h include/asm-x86/desc_defs.h+5 -80 replies
13/19move constants to desc_defs.hinclude/asm-x86/desc_32.h include/asm-x86/desc_defs.h+5 -80 replies
13/19move constants to desc_defs.hinclude/asm-x86/desc_32.h include/asm-x86/desc_defs.h+5 -80 replies
13/19move constants to desc_defs.hinclude/asm-x86/desc_32.h include/asm-x86/desc_defs.h+5 -80 replies
14/19use the same data type for tls_array.include/asm-x86/desc_64.h include/asm-x86/processor_64.h+3 -20 replies
14/19use the same data type for tls_array.include/asm-x86/desc_64.h include/asm-x86/processor_64.h+3 -20 replies
14/19unify non-paravirt parts of desc.hinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+99 -1220 replies
14/19unify non-paravirt parts of desc.hinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+99 -1220 replies
14/19unify non-paravirt parts of desc.hinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+76 -1060 replies
14/19unify non-paravirt parts of desc.hinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+76 -1060 replies
14/19unify non-paravirt parts of desc.hinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+76 -1060 replies
15/19modify get_desc_basearch/x86/kernel/tls.c arch/x86/mm/fault_32.c include/asm-x86/desc.h+4 -80 replies
15/19modify get_desc_basearch/x86/kernel/tls.c arch/x86/mm/fault_32.c include/asm-x86/desc.h+4 -80 replies
15/19use the same data type for tls_array.include/asm-x86/desc_64.h include/asm-x86/processor_64.h+3 -20 replies
15/19use the same data type for tls_array.include/asm-x86/desc_64.h include/asm-x86/processor_64.h+3 -20 replies
15/19use the same data type for tls_array.include/asm-x86/desc_64.h include/asm-x86/processor_64.h+3 -20 replies
15/19use the same data type for tls_array.include/asm-x86/desc_64.h include/asm-x86/processor_64.h+3 -20 replies
15/19use the same data type for tls_array.include/asm-x86/desc_64.h include/asm-x86/processor_64.h+3 -20 replies
16/19provide tss_descinclude/asm-x86/desc_defs.h+2 -00 replies
16/19provide tss_descinclude/asm-x86/desc_defs.h+2 -00 replies
16/19modify get_desc_basearch/x86/kernel/tls.c arch/x86/mm/fault_32.c include/asm-x86/desc.h+4 -80 replies
16/19modify get_desc_basearch/x86/kernel/tls.c arch/x86/mm/fault_32.c include/asm-x86/desc.h+4 -80 replies
16/19modify get_desc_basearch/x86/kernel/tls.c arch/x86/mm/fault_32.c include/asm-x86/desc.h +2 more+7 -190 replies
16/19modify get_desc_basearch/x86/kernel/tls.c arch/x86/mm/fault_32.c include/asm-x86/desc.h +2 more+7 -190 replies
16/19modify get_desc_basearch/x86/kernel/tls.c arch/x86/mm/fault_32.c include/asm-x86/desc.h +2 more+7 -190 replies
16/19modify get_desc_basearch/x86/kernel/tls.c arch/x86/mm/fault_32.c include/asm-x86/desc.h +2 more+7 -190 replies
17/19unify paravirt pieces of descriptor handlinginclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+169 -2160 replies
17/19unify paravirt pieces of descriptor handlinginclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+169 -2160 replies
17/19unify paravirt pieces of descriptor handlinginclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+183 -2260 replies
17/19unify paravirt pieces of descriptor handlinginclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+183 -2260 replies
17/19unify paravirt pieces of descriptor handlinginclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+183 -2260 replies
17/19unify paravirt pieces of descriptor handlinginclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+183 -2260 replies
17/19unify paravirt pieces of descriptor handlinginclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+175 -2260 replies
17/19unify paravirt pieces of descriptor handlinginclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h +1 more+175 -2260 replies
18/19move _set_gate and its users to a common locationarch/x86/kernel/traps_32.c include/asm-x86/desc.h include/asm-x86/desc_32.h +2 more+89 -1260 replies
18/19move _set_gate and its users to a common locationarch/x86/kernel/traps_32.c include/asm-x86/desc.h include/asm-x86/desc_32.h +2 more+89 -1260 replies
18/19move _set_gate and its users to a common locationarch/x86/kernel/traps_32.c include/asm-x86/desc.h include/asm-x86/desc_32.h +2 more+89 -990 replies
18/19move _set_gate and its users to a common locationarch/x86/kernel/traps_32.c include/asm-x86/desc.h include/asm-x86/desc_32.h +2 more+89 -990 replies
18/19move _set_gate and its users to a common locationarch/x86/kernel/traps_32.c include/asm-x86/desc.h include/asm-x86/desc_32.h +2 more+89 -990 replies
18/19move _set_gate and its users to a common locationarch/x86/kernel/traps_32.c include/asm-x86/desc.h include/asm-x86/desc_32.h +2 more+89 -990 replies
18/19move _set_gate and its users to a common locationarch/x86/kernel/traps_32.c include/asm-x86/desc.h include/asm-x86/desc_32.h +2 more+89 -990 replies
18/19move _set_gate and its users to a common locationarch/x86/kernel/traps_32.c include/asm-x86/desc.h include/asm-x86/desc_32.h +2 more+89 -992 replies
19/19unify set_tss_descinclude/asm-x86/desc.h include/asm-x86/desc_64.h+33 -410 replies
19/19unify set_tss_descinclude/asm-x86/desc.h include/asm-x86/desc_64.h+33 -410 replies
19/19unify set_tss_descinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h+33 -680 replies
19/19unify set_tss_descinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h+33 -680 replies
19/19unify set_tss_descinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h+33 -663 replies
19/19unify set_tss_descinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h+20 -660 replies
19/19unify set_tss_descinclude/asm-x86/desc.h include/asm-x86/desc_32.h include/asm-x86/desc_64.h+20 -660 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/19] desc_struct integration

Hi,

this is a series of patches that unify the struct desc_struct and friends across x86_64 and i386. As usual, it provides paravirt capabilities as a side-effect for x86_64.

I consider the main goal, namely, of unifying the desc_struct, an ongoing effort, being this the beginning. A lot of old code has to be touched to accomplish that.

I don't consider this patch ready for inclusion. Basically, the main reason is that I change the signatures of write_idt_entry(), write_gdt_entry(), and write_ldt_entry(). This is needed to account for the differences between the two architectures. (For example, gate descriptors in x86_64 are 16-byte long and can't be represented by low and high entries). As my patch series were 64-bit only, I hadn't come across the problem before.

I think this interface is sane, but I'd like to hear opinions. Specially from Jeremy and Zach, since it would touch xen and vmi code. The later, by the way, is _not_ included in this series. Being the interface acked, we still have to write it.

Thanks in advance for the review in opinions to come.