RFC
Status from this message: Applied. Thanks. BTW, one question:
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest34 patches 46 repliesApplied
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/34 | Introduce new SQL schema.doc/ doc/ include/ +2 more | +1120 | 10 replies | |
| 2/34 | Do not propagate one conntrack event via 2 messagesinput/ | +168 | 6 replies | |
| 3/34 | Use an enum to clarify code.util/ | +28 | 1 reply | |
| 4/34 | Adapt printflow for one conntrack entry per line format.include/ util/ | +123 | 1 reply | |
| 5/34 | Add --info option which displays information about plugin.src/ | +133 | 1 reply | |
| 6/34 | New version of SQL schema.doc/ doc/ | +213 | 1 reply | |
| 7/34 | Changed sighup_handler_print to fallback to continue using old descriptor on new file opening failure.output/ | +4 | 1 reply | |
| 8/34 | Added explicit null termination of the hostname bufferfilter/ | +1 | 1 reply | |
| 9/34 | For OPRINT, changed sighup_handler_print to fallback to continue using old descriptor on new file opening failure.output/ | +4 | 1 reply | |
| 10/34 | Add some missing line break.output/ | +2 | 1 reply | |
| 11/34 | Put O at the real end of the string.filter/ | +2 | 1 reply | |
| 12/34 | Changed to show pcap file name when open failed.output/ | +2 | 1 reply | |
| 13/34 | Display filename in the other error case.output/ | +2 | 1 reply | |
| 14/34 | Request at least autoconf 2.50 (needed for large file support macro).configure.in | +1 | 1 reply | |
| 15/34 | MySQL client library does not reconnect automatically since 5.0.output/ | +14 | 1 reply | |
| 16/34 | Introduce IP2STR module which convert IP to string.filter/ filter/ | +203 | 1 reply | |
| 17/34 | Suppress key relative to IPv6 address.filter/ include/ ulogd.conf.in +1 more | +21 | 1 reply | |
| 18/34 | Update schema for PostgreSQL.doc/ | +23 | 1 reply | |
| 19/34 | Fix options for pgsql moduleoutput/ | +2 | 1 reply | |
| 20/34 | Mark ID as inactive (sequence in pg schema)output/ | +2 | 1 reply | |
| 21/34 | Add IP2BIN module: convert IP address to binary string.filter/ filter/ | +233 | 1 reply | |
| 22/34 | Fix description and indenting.filter/ | +2 | 1 reply | |
| 23/34 | Print RAW as raw string.util/ | +1 | 1 reply | |
| 24/34 | Fix IPv4 output.filter/ | +2 | 2 replies | |
| 25/34 | Set oob.family as VALID key.input/ | +1 | 1 reply | |
| 26/34 | Modify IPv6 parser to fill oob_family.filter/ | +4 | 1 reply | |
| 27/34 | Free insertion function result (mysql)output/ | +5 | 1 reply | |
| 28/34 | Update SQL schemadoc/ doc/ | +170 | 1 reply | |
| 29/34 | Fix some place were oob_family was used instead of _oob_family.doc/ | +2 | 1 reply | |
| 30/34 | Convert SQL procedure to function call.util/ | +1 | 1 reply | |
| 31/34 | Switch from INNER JOIN to LEFT JOIN in ulog view.doc/ | +4 | 1 reply | |
| 32/34 | Add state extension.doc/ | +28 | 1 reply | |
| 33/34 | ULOGD_RET_IPADDR is for IPv4 or IPv6 address: fix description.src/ | +1 | 1 reply | |
| 34/34 | Modify insert functions to accept standard integers to avoid casts.doc/ output/ | +72 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [ULOGD RFC PATCH 0/34]
Hello,
This patchset contains patches for ulogd2 from Pierre Chifflier and I.
As discussed during Netfilter workshop, the goal of this patchset is to provide a new and modern SQL logging schema. Some colateral patchs are present in the patchset due to the state of Ulogd2. As stated by Holger, people using ulogd2 now are early adopters and we tried to improve usability of ulogd2. For example, we've added a --info switch to ulogd2 to be able to display option of a plugin.
But, the main work is on SQL logging. Ulogd 1.x schema was really bad. It lacks index and the way data are stored (one big line per entry full of NULL fields) is not efficient for databases.
Thus, we propose new schemas for MySQL and PGsql which use advanced database feature without complication on developper side. In fact, the SQL related C code did not change very much. The main change is the use of a call to a SQL function instead of using a SQL query. The advantage of doing this is to hide the complexity of the database to developpers and let people knowing databases work on their side without bothering us.
I will finished this mail by a description of the avantages of the new schema. It uses a set of small dedicated tables (a TCP tables for example). From an SQL point of view this is more efficient as we limit the number of NULL fields (storage of empty datas has a cost). The schema has some SQL views (virtual table) and some of them provides an near complete backward compatility with the existing one.
One other advantage of the new schema is that extension (like nufw one) can used without changing anything for non-aware system.
This patchset should not conflict with Holger patchset (if NFCT related work is omitted). I can do the merge work if some is needed, just let me know.
BR,
--
Eric Leblond <[email protected]>
INL: http://www.inl.fr/