Skip to content

ide: generic packet command representation

Borislav Petkov linux-ide lkml 1 version Applied

Status from this message: applied all four patches, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4ide: add generic packet command representation ide_atapi_pcinclude/linux/ide.h+47 -00 replies
2/4ide-floppy: convert driver to using generic ide_atapi_pcdrivers/ide/ide-floppy.c+93 -1120 replies
3/4ide-tape: convert driver to using generic ide_atapi_pcdrivers/ide/ide-tape.c+114 -1370 replies
4/4ide-scsi: convert driver to using generic ide_atapi_pcdrivers/scsi/ide-scsi.c+62 -710 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] ide: generic packet command representation

Hi Bart,

here's the ide_atapi_pc unification series. It all went pretty smoothly along the search & replace line. Using driver-specific members in ide_atapi_pc like idefloppy_callback and idetape_callback is kinda dumb but this approach seemed the fastest versus unnecessary callback function signature change that will touch stuff all over the place. Besides, ide-tape might be gone soon so that would alleviate the problem.

On a different note, i noticed ide-scsi might also need a cleanup similar to the other drivers. It is next on my TODO list in case you don't have anything with a higher prio.

 drivers/ide/ide-floppy.c |  205 +++++++++++++++++--------------------
 drivers/ide/ide-tape.c   |  251 +++++++++++++++++++++-------------------------
 drivers/scsi/ide-scsi.c  |  133 +++++++++++-------------
 include/linux/ide.h      |   47 +++++++++
 4 files changed, 316 insertions(+), 320 deletions(-)
Signature · 2 lines
Thanks,
Boris.