ide: generic packet command representation
Status from this message: applied all four patches, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | ide: add generic packet command representation ide_atapi_pcinclude/ | +47 | 0 replies | |
| 2/4 | ide-floppy: convert driver to using generic ide_atapi_pcdrivers/ | +93 | 0 replies | |
| 3/4 | ide-tape: convert driver to using generic ide_atapi_pcdrivers/ | +114 | 0 replies | |
| 4/4 | ide-scsi: convert driver to using generic ide_atapi_pcdrivers/ | +62 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] ide: generic packet command representation
Hi Bart,
here's the ide_atapi_pc unification series. It all went pretty smoothly along the search & replace line. Using driver-specific members in ide_atapi_pc like idefloppy_callback and idetape_callback is kinda dumb but this approach seemed the fastest versus unnecessary callback function signature change that will touch stuff all over the place. Besides, ide-tape might be gone soon so that would alleviate the problem.
On a different note, i noticed ide-scsi might also need a cleanup similar to the other drivers. It is next on my TODO list in case you don't have anything with a higher prio.
drivers/ide/ide-floppy.c | 205 +++++++++++++++++-------------------- drivers/ide/ide-tape.c | 251 +++++++++++++++++++++------------------------- drivers/scsi/ide-scsi.c | 133 +++++++++++------------- include/linux/ide.h | 47 +++++++++ 4 files changed, 316 insertions(+), 320 deletions(-)
Signature · 2 lines
Thanks, Boris.