Skip to content

Review: acpi processor hotplug

Glauber Costa kvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15Make a GPE register block be acessible.bios/rombios32.c+2 -00 replies
2/15mark extra cpus as presentbios/rombios.h bios/rombios32.c+15 -80 replies
3/15introduce cpu_set to qemu monitorqemu/hw/acpi.c qemu/monitor.c qemu/sysemu.h+22 -01 reply
4/15mark processors as presentsbios/acpi-dsdt.dsl+19 -04 replies
5/15provide gpe _L0x methodsbios/acpi-dsdt.dsl+51 -00 replies
6/15provide operation region for pio to the gpesbios/acpi-dsdt.dsl+7 -00 replies
7/15implement method _L00 for GPE0bios/acpi-dsdt.dsl+114 -00 replies
8/15isolate cpu initialization function in hw/pc.cqemu/hw/pc.c qemu/hw/pc.h+24 -170 replies
9/15initialize hot add system.qemu/hw/acpi.c qemu/hw/pc.c+36 -00 replies
10/15handle gpe data for pioqemu/hw/acpi.c+36 -00 replies
11/15manipulate the gpe bits and send sci up the os.qemu/hw/acpi.c+42 -00 replies
12/15isolate cpu thread creation in qemu-kvm.cqemu/qemu-kvm.c qemu/qemu-kvm.h+8 -20 replies
13/15provide _MAT to acpi processorbios/acpi-dsdt.dsl+140 -140 replies
14/15start a new cpu threadqemu/hw/acpi.c+16 -00 replies
15/15provide _EJ0 method for processor removalbios/acpi-dsdt.dsl qemu/pc-bios/bios.bin+14 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/15] Review: acpi processor hotplug

Hi,

In this series, I'm sending the result-so-far of my work with acpi for processor hotplug. I'm able to put a cpu up and down (with the help of some udev scripts I wrote), but it still has some known bugs and issues. For x86_64 linux machines (because the kernel supports it), you can plug cpus that _were not_ listed initially in smp_cpus.

The usage is : cpu_set x (online/offline), in qemu monitor. It will then send the proper signals to the cpu #x.

However, it is important to note that:

* there's no way to know if it suceeded. (ex, if the udev scripts are not running, the cpu will not be put up, and you'll never know)
* there's no way to unconditionally send an add signal. (if you send BUS_CHECK again, and the cpu is already marked as present, it will offline it instead)

because of that, management gets a bit complicated. The ideal situation is to specify:
"I want Y cpus", and have it. Error reported in case it fails. Because of that, I _still_ advocate for an alternative virtio implementation. ACPI still plays its role in this scenario, but not the full role.

In my TODO list, you'll find:
* fix some more issues in this code, and merge the gently comments I'm sure you'll make
* device acpi hotplug
* virtio cpu hotplug for linux (meaning refactoring the existing patch)
* occupy 24 territories.
* conquer 18 territories with at least 2 battalions on each.

Besides a bunch of boring personal items I'm sure are not of interest to anybody here.

Thanks in advance

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/