Skip to content

ide-tape: remove pipelined mode operation

Borislav Petkov linux-ide lkml 1 version Applied

Status from this message: applied

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 19 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/24ide-tape: remove idetape_pipeline_active()drivers/ide/ide-tape.c+11 -181 reply
2/24ide-tape: remove pipeline-specific code from idetape_add_chrdev_write_requestdrivers/ide/ide-tape.c+4 -775 replies
3/24ide-tape: remove pipeline-specific code from idetape_add_chrdev_read_requestdrivers/ide/ide-tape.c+1 -452 replies
4/24ide-tape: remove pipeline-specific code from idetape_chrdev_writedrivers/ide/ide-tape.c+4 -113 replies
5/24ide-tape: cleanup pipeline-specific code from idetape_init_readdrivers/ide/ide-tape.c+5 -681 reply
6/24ide-tape: remove unused stage-parameter from idetape_copy_stage_to_userdrivers/ide/ide-tape.c+4 -71 reply
7/24ide-tape: remove pipeline-specific code bits from idetape_chrdev_readdrivers/ide/ide-tape.c+8 -80 replies
8/24ide-tape: remove pipeline-specific code from idetape_space_over_filemarksdrivers/ide/ide-tape.c+1 -640 replies
9/24ide-tape: remove pipeline-specific code from idetape_mtioctopdrivers/ide/ide-tape.c+0 -80 replies
10/24ide-tape: remove pipeline-specific code from idetape_chrdev_ioctldrivers/ide/ide-tape.c+9 -300 replies
11/24ide-tape: remove pipeline-specific code from idetape_blkdev_ioctldrivers/ide/ide-tape.c+5 -120 replies
12/24ide-tape: remove idetape_empty_write_pipelinedrivers/ide/ide-tape.c+0 -750 replies
13/24ide-tape: remove pipeline-specific code from idetape_chrdev_releasedrivers/ide/ide-tape.c+8 -700 replies
14/24ide-tape: remove __idetape_discard_read_pipelinedrivers/ide/ide-tape.c+0 -490 replies
15/24ide-tape: remove pipeline-specific code from idetape_end_requestdrivers/ide/ide-tape.c+1 -1710 replies
16/24ide-tape: remove idetape_calculate_speedsdrivers/ide/ide-tape.c+0 -640 replies
17/24ide-tape: remove pipeline-specific code from idetape_chrdev_opendrivers/ide/ide-tape.c+6 -320 replies
18/24ide-tape: remove pipeline-specific code from idetape_setupdrivers/ide/ide-tape.c+4 -360 replies
19/24ide-tape: remove pipelined mode parametersdrivers/ide/ide-tape.c+0 -180 replies
20/24ide-tape: remove pipelined mode tape control flagsdrivers/ide/ide-tape.c+5 -90 replies
21/24ide-tape: remove pipeline-specific members from struct ide_tape_objdrivers/ide/ide-tape.c+2 -930 replies
22/24ide-tape: remove misc references to pipelined operation in the commentsdrivers/ide/ide-tape.c+4 -110 replies
23/24ide-tape: remove pipelined mode description from Documentation/ide/ide-tape.txtDocumentation/ide/ide-tape.txt+0 -790 replies
24/24ide-tape: remove comments markup from Documentation/ide/ide-tape.txtDocumentation/ide/ide-tape.txt+65 -670 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/24] ide-tape: remove pipelined mode operation

Hi Bart,

here's the 1st draft of the pipeline removal series. As the diffstat below openly states it, a lot of code got removed - even more than the cleanup series we did earlier. There are several issues that we need to address concerning these patches:

1. only compile-tested since i don't have the hardware, i.e. longer -mm brewing is advisable the least.

2. I have left the tape->merge_stage buffer structure along with its alloc/free functions intact for now, for simplicity. The next step would be to go and carefully audit the code and then remove that last piece too and use allocations on the stack instead. I guess we still expect Jens's response on whether blk_{get,put}_request is the way to go here.

Jens?

3. After applying those we're moving into the direction of a lightweight ide-tape driver so the stanza for its removal in Documentation/feature-removal-schedule.txt becomes incorrect.

4. ... (i'm sure you're gonna have some more :))

 Documentation/ide/ide-tape.txt |  211 +++------
 drivers/ide/ide-tape.c         | 1032 +++-------------------------------------
 2 files changed, 134 insertions(+), 1109 deletions(-)