Allow reuse of plugin instance (and misc fixes)
Status from this message: Applied. Thanks.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | Add hook to list of fields in database for packet logging.doc/ doc/ | +23 | 1 reply | |
| 2/8 | Introduce RAWSTR type to avoid confusion in future developement.filter/ include/ util/ | +11 | 1 reply | |
| 3/8 | Fix indentation in ulogd_inppkt_NFLOG.cinput/ | +1 | 1 reply | |
| 4/8 | Don't call start function multiple time for a single plugin instance.src/ | +28 | 1 reply | |
| 5/8 | Add a list of used plugininstance.include/ src/ | +4 | 1 reply | |
| 6/8 | Duplicate message to all existing instance of NFLOG.input/ | +9 | 1 reply | |
| 7/8 | Add code for duplication of message in ULOGinput/ | +5 | 1 reply | |
| 8/8 | Duplication of message in NFCT input plugininput/ | +7 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [ULOGD PATCH 0/8] Allow reuse of plugin instance (and misc fixes)
Hello,
This patchset starts with some cleaning:
- Add hook to list of fields in database for packet logging.
- Introduce RAWSTR type to avoid confusion in future developement.
- Fix indentation in ulogd_inppkt_NFLOG.c
Latest patches introduce a modification of plugin behaviour. It was not possible with existing code to reuse a plugin instance. For example, it is not possible to do :
stack=log1:NFLOG,base1:BASE,ifi1:IFINDEX,ip2str1:IP2STR,print1:PRINTPKT,emu1:LOGEMU stack=log1:NFLOG,base1:BASE,ifi1:IFINDEX,ip2str1:IP2STR,print1:PRINTPKT,emu2:LOGEMU
This kind of setup is useful to be able to log in a file and in a database for example. To be able to have such a setup it is necessary:
- Not to call twice or more start function to avoid problem (it is not possible to listen to the same nfgroup more than once)
- Duplicate the message in the INPUT module.
This patchset contains ulogd necessary modifications and modifications of NFLOG, ULOG and NFCT INPUT plugins.
The patches are :
- Don't call start function multiple time for a single plugin instance.
- Add a list of used plugininstance.
- Duplicate message to all existing instance of NFLOG.
- Add code for duplication of message in ULOG
- Duplication of message in NFCT input plugin
Global stats:
doc/mysql-ulogd2.sql | 17 +++++++++++------ doc/pgsql-ulogd2.sql | 20 ++++++++++++-------- filter/ulogd_filter_IP2BIN.c | 12 ++++++------ include/ulogd/ulogd.h | 3 +++ input/flow/ulogd_inpflow_NFCT.c | 7 +++++++ input/packet/ulogd_inppkt_NFLOG.c | 12 ++++++++++-- input/packet/ulogd_inppkt_ULOG.c | 5 +++++ src/ulogd.c | 35 ++++++++++++++++++++++++++++++----- util/db.c | 5 ++++- 9 files changed, 88 insertions(+), 28 deletions(-)
BR,
--
Eric Leblond
INL: http://www.inl.fr/
NuFW: http://www.nufw.org/