Skip to content

ip_options_compile cleanup

Denis V. Lunev netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Remove unnecessary check for opt->is_data in ip_options_compile.net/ipv4/ip_options.c+1 -20 replies
2/3Remove unused ip_options->is_data.include/net/inet_sock.h net/ipv4/cipso_ipv4.c net/ipv4/ip_options.c+1 -80 replies
3/3: Always pass ip_options pointer into ip_options_compile.net/ipv4/ip_input.c net/ipv4/ip_options.c+10 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3 net-2.6.26] ip_options_compile cleanup

This set of patches has been originally sent to to netdev@ two weeks ago.

The idea is the following: ip_options->is_data field is checked only inside ip_options_compile when opt != NULL. This is possible only on the following codepath:

    ip_options_get_finish
        opt->is_data = 1;
        ip_options_compile(opt, NULL)

ip_options->is_data is not a part of user<->kernel interface and can be removed.

Regards,
Den

Read the cover letter in its thread