Skip to content

UDP/ICMP/TCP for a namespace v2

Denis V. Lunev containers netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 11 repliesIn review

Changed from v1 from the cover letter

- inet_csk_ctl_sock_create is renamed to inet_ctl_sock_create. Thanks to Arnaldo Carvalho de Melo <[email protected] and Vlad Yasevich <[email protected]>
- dccp_ctl_make_reset now accept sock rather than socket. Thanks to Arnaldo Carvalho de Melo <[email protected]>
- added inet_ctl_sock_destroy

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13: Replace socket with sock for reset sending.net/ipv4/tcp_ipv4.c+6 -41 reply
2/13: Replace socket with sock for reset sending.net/dccp/dccp.h net/dccp/ipv4.c net/dccp/ipv6.c +1 more+19 -151 reply
3/13: dccp_v(4|6)_ctl_socket is leaked.net/dccp/ipv4.c net/dccp/ipv6.c+2 -01 reply
4/13: Rename inet_csk_ctl_sock_create to inet_ctl_sock_create.include/net/inet_common.h include/net/inet_connection_sock.h net/dccp/ipv4.c +5 more+32 -311 reply
5/13: Use inet_ctl_sock_create for control socket creation.net/sctp/protocol.c+2 -51 reply
6/13: Replace socket with sock for SCTP control socket.net/sctp/protocol.c+7 -51 reply
7/13: Let inet_ctl_sock_create return sock rather than socket.include/net/inet_common.h net/dccp/ipv4.c net/dccp/ipv6.c +4 more+14 -211 reply
8/13: Inet control socket should not hold a namespace.include/net/inet_common.h net/dccp/ipv4.c net/dccp/ipv6.c +4 more+22 -211 reply
9/13: Simplify ICMP control socket creation.net/ipv4/icmp.c+7 -181 reply
10/13: uc_ttl assignment in inet_ctl_sock_create is redundant.net/ipv4/af_inet.c+0 -10 replies
11/13: Simplify IPv6 control sockets creation.net/ipv6/icmp.c net/ipv6/mcast.c net/ipv6/ndisc.c+17 -301 reply
12/13: Create tcp control socket in the each namespace.include/net/netns/ipv4.h net/ipv4/tcp_ipv4.c+20 -20 replies
13/13: Use TCP control socket from a correct namespace.net/ipv4/tcp_ipv4.c+4 -60 replies

Reviews trailers per patch

10 of 13 patches have a Reviewed-by or Acked-by.

PatchArnaldo Carvalho de Melo
1/13A-b
2/13A-b
3/13A-b
4/13A-b
5/13A-b
6/13A-b
7/13A-b
8/13A-b
9/13A-b
10/13
11/13A-b
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/13 net-2.6.26] UDP/ICMP/TCP for a namespace v2

Hello, Dave!

This patch set finally enables TCP/UDP and ICMP inside a namespace. In order to do this we fix ARP processing, IP options processing and allow packets to flow to namespace aware protocols.

Finally, this makes namespace functional and alive :)

Changed from v1:
- inet_csk_ctl_sock_create is renamed to inet_ctl_sock_create. Thanks to Arnaldo Carvalho de Melo <[email protected] and Vlad Yasevich <[email protected]>
- dccp_ctl_make_reset now accept sock rather than socket. Thanks to Arnaldo Carvalho de Melo <[email protected]>
- added inet_ctl_sock_destroy