Skip to content

Allow built-in firmware to be accessed by request_firmware()

David Woodhouse lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest28 patches 18 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28libertas: treat firmware data as constdrivers/net/wireless/libertas/if_cs.c drivers/net/wireless/libertas/if_sdio.c drivers/net/wireless/libertas/if_usb.c+5 -51 reply
2/28bluetooth: treat firmware data as constdrivers/bluetooth/bfusb.c drivers/bluetooth/bt3c_cs.c+4 -21 reply
3/28cyclades: treat firmware data as constdrivers/char/cyclades.c+5 -51 reply
4/28cx25840: treat firmware data as constdrivers/media/video/cx25840/cx25840-firmware.c+13 -87 replies
5/28myri10ge: treat firmware data as constdrivers/net/myri10ge/myri10ge.c+9 -20 replies
6/28vx222: treat firmware data as constsound/pci/vx222/vx222_ops.c+1 -10 replies
7/28riptide: treat firmware data as constsound/pci/riptide/riptide.c+5 -50 replies
8/28pcxhr: treat firmware data as constsound/pci/pcxhr/pcxhr_core.c+2 -20 replies
9/28vx: treat firmware data as constsound/drivers/vx/vx_core.c+2 -20 replies
10/28ueagle-atm: treat firmware data as constdrivers/usb/atm/ueagle-atm.c+11 -90 replies
11/28cxacru: treat firmware data as constdrivers/usb/atm/cxacru.c+1 -10 replies
12/28aic94xx: treat firmware data as constdrivers/scsi/aic94xx/aic94xx_sds.c drivers/scsi/aic94xx/aic94xx_sds.h drivers/scsi/aic94xx/aic94xx_seq.c+12 -110 replies
13/28zd1201: treat firmware data as constdrivers/net/wireless/zd1201.c+1 -10 replies
14/28rt2x00: treat firmware data as constdrivers/net/wireless/rt2x00/rt2x00.h drivers/net/wireless/rt2x00/rt2x00pci.h drivers/net/wireless/rt2x00/rt61pci.c +1 more+8 -80 replies
15/28p54: treat firmware data as constdrivers/net/wireless/p54/p54usb.c+3 -20 replies
16/28atmel: treat firmware data as constdrivers/net/wireless/atmel.c+3 -30 replies
17/28irda-usb: treat firmware data as constdrivers/net/irda/irda-usb.c+6 -60 replies
18/28cxgb3: treat firmware data as constdrivers/net/cxgb3/common.h drivers/net/cxgb3/t3_hw.c+7 -50 replies
19/28bt8xx: treat firmware data as constdrivers/media/video/bt8xx/bttv-cards.c+2 -10 replies
20/28ttusb-dec: treat firmware data as constdrivers/media/dvb/ttusb-dec/ttusb_dec.c+1 -10 replies
21/28dvb frontends: treat firmware data as constdrivers/media/dvb/frontends/bcm3510.c drivers/media/dvb/frontends/nxt200x.c drivers/media/dvb/frontends/or51211.c +4 more+11 -90 replies
22/28cxusb: treat firmware data as constdrivers/media/dvb/dvb-usb/cxusb.c+18 -33 replies
23/28gp8psk: treat firmware data as constdrivers/media/dvb/dvb-usb/gp8psk.c+2 -10 replies
24/28tuners: treat firmware data as constdrivers/media/common/tuners/tuner-xc2028.c drivers/media/common/tuners/xc5000.c+2 -20 replies
25/28firmware: make fw->data constdrivers/base/firmware_class.c include/linux/firmware.h+2 -20 replies
26/28firmware: allow firmware files to be built into kernel imagedrivers/base/firmware_class.c include/asm-generic/vmlinux.lds.h include/linux/firmware.h+59 -22 replies
27/28firmware: Add CONFIG_BUILTIN_FIRMWARE optionMakefile drivers/base/Kconfig firmware/Makefile+71 -14 replies
28/28firmware: convert korg1212 driver to use firmware loader exclusivelyfirmware/Makefile firmware/korg/k1212.c sound/pci/korg1212/korg1212.c+5 -203 replies

Reviews trailers per patch

5 of 28 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlan CoxHans VerkuilMike IselyTyler TraffordMauro Carvalho Chehab
SeriesA-b
1/28A-b
2/28A-b
3/28A-b
4/28A-b A-b A-b A-b
5/28
6/28
7/28
8/28
9/28
10/28
11/28
12/28
13/28
14/28
15/28
16/28
17/28
18/28
19/28
20/28
21/28
22/28
23/28
24/28
25/28
26/28
27/28
28/28A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCHv2 00/28] Allow built-in firmware to be accessed by request_firmware()

Second attempt, now in the git tree at
git.infradead.org/users/dwmw2/firmware-2.6.git

At Alan's suggestion, start by making fw->data const so that we can avoid the extra vmalloc+copy when we find it built-in. Mostly straightforward, but could do with an extra pair of eyes and some testing for the cxusb, myri10ge, cx25840 and or51211 changes.

Also switch to using a .S file for the included firmware, which means we can use .incbin instead of including the whole thing in hex form in a C file. And fix up the case where there were no built-in firmware

Signature · 1 line
dwmw2

Read the cover letter in its thread