Skip to content

Generic ide device flags

Borislav Petkov linux-ide lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16ide: push pc callback pointer into the ide_drive_t structureinclude/linux/ide.h+7 -20 replies
2/16ide-floppy: use drive->pc_callback instead of pc->callbackdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c+10 -40 replies
3/16ide-tape: use drive->pc_callback instead of pc->callbackdrivers/ide/ide-atapi.c drivers/ide/ide-tape.c+6 -50 replies
4/16ide-scsi: use drive->pc_callback instead of pc->callbackdrivers/ide/ide-atapi.c drivers/scsi/ide-scsi.c+5 -100 replies
5/16ide: remove pc->callback member from ide_atapi_pcinclude/linux/ide.h+0 -20 replies
6/16ide-floppy: pass packet command in rq->cmddrivers/ide/ide-floppy.c+4 -00 replies
7/16ide-tape: make room for packet command ids in rq->cmddrivers/ide/ide-tape.c+11 -110 replies
8/16ide-tape: pass packet command in rq->cmddrivers/ide/ide-tape.c+11 -80 replies
9/16ide-scsi: pass packet command in rq->cmddrivers/scsi/ide-scsi.c+2 -00 replies
10/16ide: use rq->cmd instead of pc->c in atapi common codedrivers/ide/ide-atapi.c+13 -50 replies
11/16ide: add per-device flagsinclude/linux/ide.h+60 -00 replies
12/16ide-floppy: convert to using the new dev_flagsdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c include/linux/ide.h+31 -500 replies
13/16ide-tape: convert to using the new dev_flagsdrivers/ide/ide-tape.c+23 -450 replies
14/16ide-scsi: convert to using the new dev_flagsdrivers/scsi/ide-scsi.c+1 -160 replies
15/16ide: remove unused PC_FLAG_DRQ_INTERRUPTdrivers/ide/ide-atapi.c include/linux/ide.h+1 -30 replies
16/16ide-cd: convert to using the new dev_flagsdrivers/ide/ide-cd.c drivers/ide/ide-cd.h drivers/ide/ide-cd_ioctl.c+64 -1090 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/16] Generic ide device flags

Hi Bart,

here's another series of generic ide tweaks. The biggest change in here is the introduction of ide_drive_t->dev_flags member which replaces all flags members in the drivers structs. As a result, some PC_FLAGs become useless and got removed, details in the respective patch descriptions below. The changes have been tested with the hardware i have (i.e., ide-cd and ide-floppy).

 drivers/ide/ide-atapi.c    |   26 ++++++---
 drivers/ide/ide-cd.c       |  108 ++++++++++++++++++++---------------------
 drivers/ide/ide-cd.h       |   38 --------------
 drivers/ide/ide-cd_ioctl.c |   27 +++++------
 drivers/ide/ide-floppy.c   |   81 ++++++++++++------------------
 drivers/ide/ide-tape.c     |  116 ++++++++++++++++++-------------------------
 drivers/scsi/ide-scsi.c    |   24 ++-------
 include/linux/ide.h        |   64 +++++++++++++++++++++++--
 8 files changed, 229 insertions(+), 255 deletions(-)
Signature · 2 lines
Regards/Gruß,
Boris.