Skip to content

Minor bnx2 patches

Benjamin Li netdev 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4bnx2: In bnx2_set_mac_link() return void rather then intdrivers/net/bnx2.c+1 -31 reply
2/4bnx2: Update MODULE_DESCRIPTION to include the 5716drivers/net/bnx2.c+1 -12 replies
3/4bnx2: Remove name field from bnx2 structuredrivers/net/bnx2.c drivers/net/bnx2.h+1 -41 reply
4/4bnx2: Remove timer_interval field from the bnx2 structuredrivers/net/bnx2.c drivers/net/bnx2.h+8 -81 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [UPDATED][NET-NEXT PATCH 0/4] Minor bnx2 patches

Thanks for the comments Simon. I have integrated the changes that you have suggested. I have reposted the entire patch set in numbered form so that it could be merged in easier.

Thanks again.

-Ben

Quoted 8 lines
(quoted diff) +0 -0
@@ -7514,7 +7514,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
Quoted 5 lines
      bp->stats_ticks = USEC_PER_SEC & BNX2_HC_STATS_TICKS_HC_STAT_TICKS;
-     bp->timer_interval =  HZ;
      bp->current_interval =  HZ;

Would it make sense to set current_interval to BNX2_TIMER_INTERVAL?

Changed.

Quoted 7 lines
Quoted 7 lines
drivers/net/bnx2.h +0 -0
index cb47c98..e534c1d 100644
@@ -6701,7 +6701,7 @@ struct bnx2 {
 
Quoted 8 lines

drivers/net/bnx2.h struct bnx2 { · line 6704

Quoted 4 lines
drivers/net/bnx2.h +1 -1
      /* End of fields used in the performance code paths. */
 
-     int                     timer_interval;
+#define BNX2_TIMER_INTERVAL                  HZ

Perhaps its just me, but would it be nicer to define BNX2_TIMER_INTERVAL somewhere other than in the middle of this structure?

Moved outside of the bnx2 structure.

--------------------

Benjamin Li (4):
bnx2: In bnx2_set_mac_link() return void rather then int
bnx2: Update MODULE_DESCRIPTION to include the 5716
bnx2: Remove name field from bnx2 structure
bnx2: Remove timer_interval field from the bnx2 structure

 drivers/net/bnx2.c |   22 +++++++++-------------
 drivers/net/bnx2.h |    5 ++---
 2 files changed, 11 insertions(+), 16 deletions(-)