Minor bnx2 patches
Status from this message: Applied.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | bnx2: In bnx2_set_mac_link() return void rather then intdrivers/ | +1 | 1 reply | |
| 2/4 | bnx2: Update MODULE_DESCRIPTION to include the 5716drivers/ | +1 | 2 replies | |
| 3/4 | bnx2: Remove name field from bnx2 structuredrivers/ drivers/ | +1 | 1 reply | |
| 4/4 | bnx2: Remove timer_interval field from the bnx2 structuredrivers/ drivers/ | +8 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [UPDATED][NET-NEXT PATCH 0/4] Minor bnx2 patches
Thanks for the comments Simon. I have integrated the changes that you have suggested. I have reposted the entire patch set in numbered form so that it could be merged in easier.
Thanks again.
-Ben
Quoted 8 lines
(quoted diff) +0
-0@@ -7514,7 +7514,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)Quoted 5 lines
bp->stats_ticks = USEC_PER_SEC & BNX2_HC_STATS_TICKS_HC_STAT_TICKS;- bp->timer_interval = HZ; bp->current_interval = HZ;Would it make sense to set
current_intervaltoBNX2_TIMER_INTERVAL?
Changed.
Quoted 7 lines
Quoted 7 lines
drivers/net/bnx2.h +0
-0@@ -6701,7 +6701,7 @@ struct bnx2 {
Quoted 8 lines
drivers/net/bnx2.h struct bnx2 { · line 6704
Quoted 4 lines
drivers/net/bnx2.h +1
-1/* End of fields used in the performance code paths. */ -int timer_interval; +#define BNX2_TIMER_INTERVAL HZPerhaps its just me, but would it be nicer to define
BNX2_TIMER_INTERVALsomewhere other than in the middle of this structure?
Moved outside of the bnx2 structure.
--------------------
Benjamin Li (4):
bnx2: In bnx2_set_mac_link() return void rather then int
bnx2: Update MODULE_DESCRIPTION to include the 5716
bnx2: Remove name field from bnx2 structure
bnx2: Remove timer_interval field from the bnx2 structure
drivers/net/bnx2.c | 22 +++++++++------------- drivers/net/bnx2.h | 5 ++--- 2 files changed, 11 insertions(+), 16 deletions(-)