Skip to content

RFC current relay cleanup patchset

Tom Zanussi linux-mm lkml 1 version New

Get series with b4
b4 am 1222322825.6435.55.camel@charm-linux

Versions newest first

  1. v1 RFC Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8relay - Clean up relay_switch_subbuf() and make waking up consumers optional.include/linux/relay.h kernel/relay.c+75 -190 replies
2/8relay - Make the relay sub-buffer switch code replaceable.include/linux/relay.h kernel/relay.c+25 -100 replies
3/8relay - Add channel flags to relay, remove global callback param.block/blktrace.c include/linux/relay.h kernel/relay.c +1 more+26 -270 replies
4/8relay - Add reserved param to switch-subbuf, in preparation for non-pad write/reserve.include/linux/relay.h kernel/relay.c+25 -110 replies
5/8relay - Map the first sub-buffer at the end of the buffer, for temporary convenience.kernel/relay.c+15 -110 replies
6/8relay - Replace relay_reserve/relay_write with non-padded versions.include/linux/relay.h kernel/relay.c+65 -450 replies
7/8relay - Remove padding-related code from relay_read()/relay_splice_read() et al.kernel/relay.c+20 -1290 replies
8/8relay - Clean up remaining padding-related junk.block/blktrace.c include/linux/relay.h kernel/relay.c +1 more+13 -300 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/8] current relay cleanup patchset

Here's the current relay cleanup patchset. The first two patches make the write path completely replaceable, the third adds flags along with some related cleanup, and the next 5 remove the padding in several stages.

It's a work in progress, but because I wanted the intermediate stages to actually work and not break anything, some of these patches, especially 05, are just temporary and will be removed in the next iteration.

I didn't have time to clean up the first 3 either - I'll also do that the next time around.

Anyway, removing the padding has simplified the read/splice code significantly; it's always been a source of headaches so I'm glad it's gone, and it doesn't seem to have broken anything - a quick test using blktrace in both read() and splice() modes didn't show any problems.

In the next round I plan to do vmap and sub-buffer removal.

Tom