Skip to content

XFS: clean up sync code

Dave Chinner linux-xfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10XFS: split out two helpers from xfs_syncsubfs/xfs/linux-2.6/xfs_sync.c+93 -690 replies
2/10XFS: Use struct inodes instead of vnodes to kill vn_grabfs/xfs/linux-2.6/xfs_sync.c fs/xfs/linux-2.6/xfs_vnode.c fs/xfs/linux-2.6/xfs_vnode.h +1 more+37 -430 replies
3/10XFS: use xfs_sync_inodes rather than xfs_syncsubfs/xfs/linux-2.6/xfs_sync.c fs/xfs/linux-2.6/xfs_sync.h fs/xfs/quota/xfs_qm_syscalls.c +2 more+16 -250 replies
4/10XFS: kill xfs_syncsubfs/xfs/linux-2.6/xfs_sync.c+62 -790 replies
5/10XFS: xfssyncd: don't call xfs_syncfs/xfs/linux-2.6/xfs_sync.c+14 -20 replies
6/10XFS: make SYNC_ATTR no longer use xfs_syncfs/xfs/linux-2.6/xfs_super.c fs/xfs/linux-2.6/xfs_sync.c fs/xfs/linux-2.6/xfs_sync.h +1 more+14 -150 replies
7/10XFS: make SYNC_DELWRI no longer use xfs_sync V2fs/xfs/linux-2.6/xfs_super.c fs/xfs/linux-2.6/xfs_sync.c fs/xfs/linux-2.6/xfs_sync.h +1 more+50 -210 replies
8/10XFS: Kill SYNC_CLOSEfs/xfs/linux-2.6/xfs_super.c fs/xfs/linux-2.6/xfs_sync.c fs/xfs/linux-2.6/xfs_sync.h+2 -400 replies
9/10XFS: Kill xfs_sync()fs/xfs/linux-2.6/xfs_sync.c fs/xfs/linux-2.6/xfs_sync.h fs/xfs/quota/xfs_qm.c +1 more+29 -1530 replies
10/10XFS: Move remaining quiesce code.fs/xfs/linux-2.6/xfs_super.c fs/xfs/linux-2.6/xfs_sync.c fs/xfs/linux-2.6/xfs_sync.h +2 more+59 -590 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/10] XFS: clean up sync code

xfs_sync and xfs_syncsub are multiplexed interfaces that shares relatively little code between callers. Because it is a multiplexed interface, it's hard to tell what is executed in each context it is called.

Factor out the sync code and explicitly call the sync functions needed rather than the multiplexed interfaces. Once this is done, we can remove xfs_syncsub and xfs_sync altogether.