Skip to content

x86: disable virt on kdump and emergency_restart (v4)

Eduardo Habkost kexec kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12kvm: vmx: move vmx.h to include/asmarch/x86/include/asm/vmx.h arch/x86/kvm/mmu.c arch/x86/kvm/vmx.c +1 more+361 -3610 replies
2/12kvm: svm: move svm.h to include/asmarch/x86/include/asm/svm.h arch/x86/kvm/kvm_svm.h arch/x86/kvm/svm.h+329 -3290 replies
3/12kvm: vmx: move ASM_VMX_* definitions from asm/kvm_host.h to asm/vmx.harch/x86/include/asm/kvm_host.h arch/x86/include/asm/vmx.h+15 -120 replies
4/12kvm: vmx: move cpu_has_kvm_support() to an inline on asm/virtext.harch/x86/include/asm/virtext.h arch/x86/kvm/vmx.c+33 -20 replies
5/12x86: asm/virtext.h: add cpu_vmxoff() inline functionarch/x86/include/asm/virtext.h+15 -00 replies
6/12kvm: vmx: extract kvm_cpu_vmxoff() from hardware_disable()arch/x86/kvm/vmx.c+11 -20 replies
7/12x86: cpu_emergency_vmxoff() functionarch/x86/include/asm/virtext.h+23 -00 replies
8/12kvm: svm: move has_svm() code to asm/virtext.harch/x86/include/asm/virtext.h arch/x86/kvm/svm.c+46 -140 replies
9/12kvm: svm: move svm_hardware_disable() code to asm/virtext.harch/x86/include/asm/virtext.h arch/x86/kvm/svm.c+15 -50 replies
10/12x86: cpu_emergency_svm_disable() functionarch/x86/include/asm/virtext.h+8 -00 replies
11/12kdump: forcibly disable VMX and SVM on machine_crash_shutdown()arch/x86/kernel/crash.c+18 -00 replies
12/12x86: disable VMX on all CPUs on rebootarch/x86/kernel/reboot.c+61 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] x86: disable virt on kdump and emergency_restart (v4)

Hi, Ingo,

This is yet another spin of the series to disable vmx on kdump and on emergency_restart, after some feedback from Avi.

The only change from v3 is that vmx.h and svm.h were moved from arch/x86/kvm to arch/x86/include/asm, instead of moving code from those headers to asm/virtext.h.

I haven't tested the SVM changes on AMD CPUs. The changes are really simple, but some testing is welcome.

This series is against tip.git#master, that already contains the nmi_shootdown_cpus() changes I've submitted previously.

For reference, this is the history of the patchset:

v1: Implemented the changes using a function pointer registering interface
where KVM could hook the virt-disable functions
v2: Style fixes
v3: Implemented the changes by moving the virt-disable code from KVM
to inline functions on asm/virtext.h
v4: Move KVM svm.h and vmx.h to include/asm, instead of moving
pieces of their contents to asm/virtext.h

Signature · 1 line
Eduardo