Skip to content

fix block timeout residue problems

James Bottomley linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7aacraid: switch to block timeoutdrivers/scsi/aacraid/linit.c+2 -20 replies
2/7ibmvscsi: switch to block timeoutdrivers/scsi/ibmvscsi/ibmvscsi.c+1 -10 replies
3/7megaraid_sas: switch to block timeoutdrivers/scsi/megaraid/megaraid_sas.c+2 -11 reply
4/7make scsi_eh_try_stu use block timeoutdrivers/scsi/scsi_error.c+1 -21 reply
5/7st: update to use block timeoutdrivers/scsi/st.c+28 -191 reply
6/7stex: switch to block timeoutdrivers/scsi/stex.c+1 -10 replies
7/7remove timeout from struct scsi_deviceinclude/scsi/scsi_device.h+0 -20 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchKai Makisara
1/7
2/7
3/7
4/7
5/7A-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] fix block timeout residue problems

It looks like there was only a partial conversion of the SCSI layer to the block timeout. The missing piece was killing timeout in struct scsi_device and leaving it with a zero value. This has already resulted in a regression:

http://bugzilla.kernel.org/show_bug.cgi?id=12120

But on closer inspection, there were lots of other dangling driver uses of the timeout value which would likewise have introduced hard to trace regressions.

This patch series eliminates the timeout variable from struct scsi_device and makes everything uniformly use the block timeout. Any wrong use of the scsi device timeout will now result in a compile failure.

It's getting late in the -rc series to push this through, but hopefully it won't delay 2.6.28 too much.

James