ide-atapi: remove ide_atapi_pc from the irq handler
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | ide-atapi: remove PC_FLAG_WRITING atapi flagdrivers/ drivers/ drivers/ +2 more | +10 | 0 replies | |
| 2/9 | ide-atapi: replace pc->flags with drive->pc_flagsdrivers/ drivers/ drivers/ +3 more | +103 | 0 replies | |
| 3/9 | ide-atapi: replace pc->buf with rq->data in the irq handlerdrivers/ drivers/ drivers/ | +33 | 0 replies | |
| 4/9 | ide-atapi: replace pc->req_xfer with drive->pc_req_xferdrivers/ drivers/ drivers/ +1 more | +22 | 0 replies | |
| 5/9 | ide-atapi: replace pc->buf_size with drive->pc_buf_sizedrivers/ drivers/ drivers/ +2 more | +8 | 0 replies | |
| 6/9 | ide-atapi: remove pc arg to drive->pc_io_buffersdrivers/ drivers/ include/ | +13 | 0 replies | |
| 7/9 | ide-atapi: use rq pointer directly instead of pc->rq derefdrivers/ | +2 | 0 replies | |
| 8/9 | ide-atapi: replace pc->error with drive->pc_errordrivers/ drivers/ drivers/ +1 more | +16 | 0 replies | |
| 9/9 | ide-atapi: remove pc arg to drive->pc_update_buffersdrivers/ drivers/ drivers/ +1 more | +16 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/9] ide-atapi: remove ide_atapi_pc from the irq handler
Hi Bart,
here's a first attempt at removing all references to ide_atapi_pc in the ATAPI IRQ handler. I've moved some of the members to the drive struct and will deal with them later :). The next step is to add an ide_atapi_queue_pc() routine similar to ide_cd_queue_pc() and then rewrite all functions in the drivers to use struct requests and local buffers instead of pc->buf and then, after that works reliably, finally get rid of ide_atapi_pc completely.
This has been tested with ide-floppy.
drivers/ide/ide-atapi.c | 123 ++++++++++++++++------------- drivers/ide/ide-floppy.c | 56 +++++++------- drivers/ide/ide-floppy.h | 4 +- drivers/ide/ide-floppy_ioctl.c | 19 +++-- drivers/ide/ide-tape.c | 173 ++++++++++++++++++++++------------------ include/linux/ide.h | 20 +++-- 6 files changed, 214 insertions(+), 181 deletions(-)