ide-cd: first conversion batch
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | ide-atapi: compute cmd_len based on device type in ide_transfer_pcdrivers/ | +13 | 0 replies | |
| 2/8 | ide-atapi: assign expiry and timeout based on device typedrivers/ | +20 | 1 reply | |
| 3/8 | ide-atapi: split drive-specific functionality in ide_issue_pcdrivers/ | +20 | 0 replies | |
| 4/8 | ide-cd: remove xferlen arg to cdrom_start_packet_commanddrivers/ | +5 | 0 replies | |
| 5/8 | ide-cd: remove handler wrappersdrivers/ | +48 | 1 reply | |
| 6/8 | ide-atapi: remove timeout arg to ide_issue_pcdrivers/ drivers/ drivers/ +1 more | +9 | 0 replies | |
| 7/8 | ide-atapi: put the rest of non-ide-cd code into the else-clause of ide_transfer_pcdrivers/ | +8 | 0 replies | |
| 8/8 | ide-atapi: start dma in a drive-specific waydrivers/ | +11 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/8] ide-cd: first conversion batch
Hi Bart,
here's the first batch of conversion patches. Now ide_issue_pc/ide_transfer_pc are almost completely aligned to their ide-cd counterparts cdrom_start_packet_command/cdrom_transfer_packet_command. The only thing missing is the setting of the irq handler through ide_set_handler but this is not that trivial since if i'd moved ide-cd's irq handler to ide-atapi that would suck in a bunch of other ide-cd functions which is not what we want, (yes/no)? and I'm going to have to ponder a little bit more on that.
Those have been lightly tested with ide-cd and ide-floppy.
drivers/ide/ide-atapi.c | 115 ++++++++++++++++---------------------------- drivers/ide/ide-cd.c | 121 ++++++++++++++++++++++++++++------------------ drivers/ide/ide-floppy.c | 2 +- drivers/ide/ide-tape.c | 2 +- include/linux/ide.h | 2 +- 5 files changed, 117 insertions(+), 125 deletions(-)