rework of nf_log refactoring
Get series with b4
b4 am 1231452093.10299.2.camel@ice-ageVersions newest first
- v1 Latest6 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | netfilter: use a linked list of loggers.include/ net/ | +91 | 0 replies | |
| 1/6 | netfilter: use a linked list of loggers.include/ net/ | +91 | 0 replies | |
| 2/6 | netfilter: suppress nf_log_unregister_pf function.include/ net/ | +0 | 0 replies | |
| 2/6 | netfilter: suppress nf_log_unregister_pf function.include/ net/ | +0 | 0 replies | |
| 3/6 | netfilter: bind at registration if no logger is already set.net/ | +6 | 0 replies | |
| 3/6 | netfilter: bind at registration if no logger is already set.net/ | +6 | 0 replies | |
| 4/6 | netfilter: convert logger modules to new API.net/ net/ net/ | +10 | 1 reply | |
| 4/6 | netfilter: convert logger modules to new API.net/ net/ net/ +1 more | +11 | 0 replies | |
| 5/6 | netfilter: print the list of register loggers.net/ | +15 | 1 reply | |
| 5/6 | netfilter: print the list of register loggers.net/ | +20 | 0 replies | |
| 6/6 | netfilter: sysctl support of logger choice.include/ net/ | +74 | 0 replies | |
| 6/6 | netfilter: sysctl support of logger choice.include/ net/ | +88 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/6] rework of nf_log refactoring
Hi,
Quoted 11 lines · Jan Engelhardt
net/netfilter/nf_log.c static int seq_show(struct seq_file *s, void *v) · line 177
Quoted 9 lines · Eric Leblond
net/netfilter/nf_log.c +3
-0@@ -172,13 +172,26 @@ static int seq_show(struct seq_file *s, void *v) {loff_t *pos = v;const struct nf_logger *logger; +struct nf_logger *t; +char loggers_string[256 ]; +int len =256 ;
Thanks Jan for your help. I've updated the patchset to follow your remarks. It uses seq_printf instead of a strncat for the proc modification and I've added the __read_mostly attribute.
Last modification of the patchset is a fix a of a bug in sysctl handling.
BR,
Signature · 3 lines
Eric Leblond <[email protected]> INL: http://www.inl.fr/ NuFW: http://www.nufw.org/