Skip to content

rework of nf_log refactoring

Eric Leblond netfilter-devel 1 version In review

Get series with b4
b4 am 1231452093.10299.2.camel@ice-age

Versions newest first

  1. v1 Latest6 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6netfilter: use a linked list of loggers.include/net/netfilter/nf_log.h net/netfilter/nf_log.c+91 -260 replies
1/6netfilter: use a linked list of loggers.include/net/netfilter/nf_log.h net/netfilter/nf_log.c+91 -260 replies
2/6netfilter: suppress nf_log_unregister_pf function.include/net/netfilter/nf_log.h net/netfilter/nf_log.c+0 -160 replies
2/6netfilter: suppress nf_log_unregister_pf function.include/net/netfilter/nf_log.h net/netfilter/nf_log.c+0 -160 replies
3/6netfilter: bind at registration if no logger is already set.net/netfilter/nf_log.c+6 -10 replies
3/6netfilter: bind at registration if no logger is already set.net/netfilter/nf_log.c+6 -10 replies
4/6netfilter: convert logger modules to new API.net/ipv4/netfilter/ipt_LOG.c net/ipv6/netfilter/ip6t_LOG.c net/netfilter/nfnetlink_log.c+10 -51 reply
4/6netfilter: convert logger modules to new API.net/ipv4/netfilter/ipt_LOG.c net/ipv4/netfilter/ipt_ULOG.c net/ipv6/netfilter/ip6t_LOG.c +1 more+11 -60 replies
5/6netfilter: print the list of register loggers.net/netfilter/nf_log.c+15 -21 reply
5/6netfilter: print the list of register loggers.net/netfilter/nf_log.c+20 -20 replies
6/6netfilter: sysctl support of logger choice.include/linux/sysctl.h net/netfilter/nf_log.c+74 -10 replies
6/6netfilter: sysctl support of logger choice.include/linux/sysctl.h net/netfilter/nf_log.c+88 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] rework of nf_log refactoring

Hi,

Quoted 11 lines · Jan Engelhardt

net/netfilter/nf_log.c static int seq_show(struct seq_file *s, void *v) · line 177

Quoted 9 lines · Eric Leblond
net/netfilter/nf_log.c +3 -0
@@ -172,13 +172,26 @@ static int seq_show(struct seq_file *s, void *v)
 {
 	loff_t *pos = v;
 	const struct nf_logger *logger;
+	struct nf_logger *t;
+	char loggers_string[256];
+	int len = 256;

Thanks Jan for your help. I've updated the patchset to follow your remarks. It uses seq_printf instead of a strncat for the proc modification and I've added the __read_mostly attribute.

Last modification of the patchset is a fix a of a bug in sysctl handling.

BR,

Signature · 3 lines
Eric Leblond <[email protected]>
INL: http://www.inl.fr/
NuFW: http://www.nufw.org/