Skip to content

Convert acked !GENERIC_TIME architectures to use the generic timekeeping core.

john stultz lkml 2 versions – In review

Get series with b4
b4 am 1239759163.6064.25.camel@localhost

Versions newest first · linked by author and title

  1. v1 Latest posting 2/22 patches 2 repliesIn review
  2. v1 posting 1/23 patches 0 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Create arch_gettimeoffset infrastructure for use in the generic timekeeping core.include/linux/time.h kernel/time/timekeeping.c+22 -00 replies
2/2Convert sh to use arch_getoffset() infrastructure.arch/sh/Kconfig arch/sh/include/asm/timer.h arch/sh/kernel/time_32.c +3 more+16 -11415 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchPaul Mundt
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RESEND][PATCH 0/2] Convert acked !GENERIC_TIME architectures to use the generic timekeeping core.

Andrew, All,

Its been two and a half years since the GENERIC_TIME infrastructure
landed. It allowed architectures that have free running counters to only have to provide a clocksource driver and leave the rest of the timekeeping management to generic code.

So far out of the 23 architectures we've fully converted 15 of them over to GENERIC_TIME. The remaining 8 (alpha, arm, blackfin, cris, m32r, m68k, sh, sparc) have in some cases been able to convert, but not fully. The issue that keeps most architectures from converting is that they do not have free running counters. They instead use the counter on their tick timer to determine their inter-tick time. This counter usually wraps every interrupt, so its not really efficient to use as a clocksource.

This has created some difficulty as the generic timekeeping core has had to deal with both GENERIC_TIME arches as well as !GENERIC_TIME arches, and since it didn't manage 100% of the calculation in the !GENERIC_TIME case, we've been limited in some of the changes we could make.

So since these last remaining architectures are unlikely to be able to fully convert to GENERIC_TIME as it stands, the generic core should try to adopt to their needs so we can bring them into the fold and reduce code duplication.

The solution is to provide a arch callout from the generic timekeeping
core: arch_gettimeoffset(). On architectures that do not provide a clocksource, the jiffies clocksource is used, and arch_gettimeoffset is added in to create finer grained inter-tick time.

The patchset I'm submitting for -mm does the following:
1) Introduces the arch_gettimeoffset infrastructure to the timekeeping core.
2) Converts Acked arch (sh) to use the arch_gettimeoffset()hook.

The sparc arch was earlier acked, but I found some complications when cross-compile testing it, so I'll be reworking it and requesting a new ack later.

I still have patches for the 6 other arches that need to be converted, but have not received acks for them yet. Instead of stalling the patchset for all of those arches, I'm submitting these, so overloaded arch maintainers can convert their arches or take my patches on their schedule without blocking arches that are ready to go.

Once all 8 arches are converted, I'll send a final cleanup patch that removes all conditionals and references to GENERIC_TIME.

I'll be sending the unacked patches I'm not submitting to -mm shortly.

Credits to Roman for initially suggesting the idea quite awhile back.

thanks
-john