Skip to content

hardware time stamping with new fields in shinfo

Patrick Ohly lkml netdev 1 version In review

Get series with b4
b4 am 1234450670.5914.9.camel@ecld0pohly

Versions newest first

  1. v1 Latest10 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10clocksource: allow usage independent of timekeeping.cinclude/linux/clocksource.h kernel/time/clocksource.c+177 -00 replies
1/10clocksource: allow usage independent of timekeeping.cinclude/linux/clocksource.h kernel/time/clocksource.c+177 -00 replies
2/10timecompare: generic infrastructure to map between two time basesinclude/linux/timecompare.h kernel/time/Makefile kernel/time/timecompare.c+317 -10 replies
2/10timecompare: generic infrastructure to map between two time basesinclude/linux/timecompare.h kernel/time/Makefile kernel/time/timecompare.c+317 -10 replies
3/10net: new user space API for time stamping of incoming and outgoing packetsDocumentation/networking/timestamping.txt Documentation/networking/timestamping/.gitignore Documentation/networking/timestamping/Makefile +23 more+883 -00 replies
3/10net: new user space API for time stamping of incoming and outgoing packetsDocumentation/networking/timestamping.txt Documentation/networking/timestamping/.gitignore Documentation/networking/timestamping/Makefile +23 more+883 -00 replies
4/10net: infrastructure for hardware time stampinginclude/linux/skbuff.h net/core/dev.c net/core/skbuff.c+161 -30 replies
4/10net: infrastructure for hardware time stampinginclude/linux/skbuff.h net/core/dev.c net/core/skbuff.c+161 -30 replies
5/10net: socket infrastructure for SO_TIMESTAMPINGinclude/net/sock.h net/compat.c net/core/sock.c +1 more+186 -420 replies
5/10net: socket infrastructure for SO_TIMESTAMPINGinclude/net/sock.h net/compat.c net/core/sock.c +1 more+186 -420 replies
6/10ip: support for TX timestamps on UDP and RAW socketsDocumentation/networking/timestamping.txt include/net/ip.h net/can/raw.c +4 more+19 -00 replies
6/10ip: support for TX timestamps on UDP and RAW socketsDocumentation/networking/timestamping.txt include/net/ip.h net/can/raw.c +4 more+19 -00 replies
7/10net: pass new SIOCSHWTSTAMP through to device driversfs/compat_ioctl.c net/core/dev.c+8 -00 replies
7/10net: pass new SIOCSHWTSTAMP through to device driversfs/compat_ioctl.c net/core/dev.c+8 -00 replies
8/10igb: access to NIC timedrivers/net/igb/e1000_regs.h drivers/net/igb/igb.h drivers/net/igb/igb_main.c+143 -00 replies
8/10igb: access to NIC timedrivers/net/igb/e1000_regs.h drivers/net/igb/igb.h drivers/net/igb/igb_main.c+143 -00 replies
9/10igb: stub support for SIOCSHWTSTAMPdrivers/net/igb/igb_main.c+31 -00 replies
9/10igb: stub support for SIOCSHWTSTAMPdrivers/net/igb/igb_main.c+31 -00 replies
10/10igb: use timecompare to implement hardware time stampingdrivers/net/igb/e1000_82575.h drivers/net/igb/e1000_defines.h drivers/net/igb/e1000_regs.h +2 more+304 -80 replies
10/10igb: use timecompare to implement hardware time stampingdrivers/net/igb/e1000_82575.h drivers/net/igb/e1000_defines.h drivers/net/igb/e1000_regs.h +2 more+304 -80 replies

Reviews trailers per patch

4 of 20 patches have a Reviewed-by or Acked-by.

PatchJohn Stultz
1/10A-b A-b
1/10A-b A-b
2/10A-b A-b
2/10A-b A-b
3/10
3/10
4/10
4/10
5/10
5/10
6/10
6/10
7/10
7/10
8/10
8/10
9/10
9/10
10/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH NET-NEXT 0/10] hardware time stamping with new fields in shinfo

Hello!

This revision of the patch series transports hardware time stamps from the hardware into user space via additional fields in struct skb_shared_info. It's based on net-next-2.6 as of this morning.

This is the solution that emerged from the discussion of the other approaches suggested before (reuse tstamp, extend skbuff, optional structs): it has the advantage of not touching skbuff and also has the simplest implementation.

The clocksource and timecompare patches have been reviewed by John Stultz. He doesn't mind merging them via the net subtree.

John Ronciak reviewed the igb driver patches. He suggested to merge the patches as they; after all, PTPd already works fine. I just tested again on 32 and 64 bit x86, both with the timestamping example programs as well as with PTPd. Latest patched PTPd is here:
http://github.com/pohly/ptpd/tree/master

The open TODOs in the igb driver will be fixed. We think that this will be easier with the infrastructure and the driver in a regular kernel tree.

David, I hope you consider the patches acceptable now. If not, then as
before: please let me know what I can do to make them acceptable.

Signature · 6 lines
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.