RFC dm_report attribute handling and liblvm vg attributes
Get series with b4
b4 am 1234531174.2731.129.camel@f10-node1Versions newest first
- v1 RFC Latest0 of 12 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 12 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/12] dm_report attribute handling and liblvm vg attributes
Quoted 15 lines · Dave Wysochanski
The purpose of this patchset is to get feedback on one approach to handling attributes in liblvm. The most important patches are:
1/12: Addsdm_report_output_attribute()function and related structures. 9/12: Updatesvg_opento store vg attributes in the handle. This allows us to use the report memory safely (we free it invg_close(). 10/12: Addlvm_vg_get_attr_list()andlvm_vg_get_attr().What is missing in the patch is the mode (read/write) of the attribute. I have not thought extensively about this but one option is as follows. Add a 'mode' or '
is_writable' field to the dm structure, and set it to 'readonly' for all attributes output bydm_report_output_attribute(). Then invg_open(), depending on the mode and capabilities of the current release of liblvm code, we can gradually change various attributes to writeable.
Quoted 3 lines
This patchset should build fine but with some warnings. Attribute code was exercised with test code in last patch.
These patches should apply cleanly on top of the following commit:
commit 9487820c32ded20b71422e79e74732273f1c4bef
Author: Christine Caulfield <[email protected]> Date: Wed Feb 11 10:13:20 2009 +0000
Add a fully-functional get_cluster_name() to clvmd corosync
interface.
Quoted 4 lines
--
lvm-devel mailing list
lvm-devel at redhat.com
https://www.redhat.com/mailman/listinfo/lvm-devel