Skip to content

ide: flags query macros

Borislav Petkov linux-ide lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ide: add flags query macrosinclude/linux/ide.h+166 -04 replies
2/10ide-cd: use flags query macrosdrivers/ide/ide-cd.c drivers/ide/ide-cd_ioctl.c+31 -310 replies
3/10ide-floppy: use flags query macrosdrivers/ide/ide-floppy.c drivers/ide/ide-floppy_ioctl.c+4 -40 replies
4/10ide-tape: use flags query macrosdrivers/ide/ide-tape.c+6 -60 replies
5/10ide-atapi: use flags query macrosdrivers/ide/ide-atapi.c+7 -80 replies
6/10ide-disk: use flags query macrosdrivers/ide/ide-disk.c drivers/ide/ide-disk_proc.c+15 -150 replies
7/10ide-devsets: use flags query macrosdrivers/ide/ide-devsets.c+3 -50 replies
8/10ide-eh: use flags query macrosdrivers/ide/ide-eh.c+8 -90 replies
9/10ide-probe: use flags query macrosdrivers/ide/ide-probe.c+18 -160 replies
10/10ide: use flags query macros in the remaining ide codedrivers/ide/cmd640.c drivers/ide/ht6560b.c drivers/ide/ide-disk.c +15 more+44 -530 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/10] ide: flags query macros

Hi,

this series adds the drive->atapi_flags and drive->dev_flags macro wrappers we discussed. The idea was to make the code more readable and this has been my main concern when coming up with the macro naming, therefore some macro names appear a tad more descriptive than the flag itself.

 drivers/ide/cmd640.c           |    2 +-
 drivers/ide/ht6560b.c          |    3 +-
 drivers/ide/ide-atapi.c        |   15 ++++++-------
 drivers/ide/ide-cd.c           |   44 ++++++++++++++++++++-------------------
 drivers/ide/ide-cd_ioctl.c     |   18 +++++++---------
 drivers/ide/ide-devsets.c      |    8 ++----
 drivers/ide/ide-disk.c         |   32 ++++++++++++++--------------
 drivers/ide/ide-disk_proc.c    |    2 +-
 drivers/ide/ide-dma.c          |    3 +-
 drivers/ide/ide-eh.c           |   17 +++++++--------
 drivers/ide/ide-floppy.c       |    6 ++--
 drivers/ide/ide-floppy_ioctl.c |    2 +-
 drivers/ide/ide-gd.c           |   14 ++++++------
 drivers/ide/ide-io.c           |    9 +++----
 drivers/ide/ide-ioctls.c       |    6 ++--
 drivers/ide/ide-iops.c         |    6 ++--
 drivers/ide/ide-lib.c          |    2 +-
 drivers/ide/ide-park.c         |   11 ++++-----
 drivers/ide/ide-pm.c           |    2 +-
 drivers/ide/ide-probe.c        |   36 +++++++++++++++++---------------
 drivers/ide/ide-proc.c         |    2 +-
 drivers/ide/ide-tape.c         |   12 +++++-----
 drivers/ide/ide-taskfile.c     |   16 +++++---------
 drivers/ide/ns87415.c          |    5 +--
 drivers/ide/pdc202xx_old.c     |    4 +-
 drivers/ide/sc1200.c           |    2 +-
 drivers/ide/trm290.c           |    4 +-
 27 files changed, 136 insertions(+), 147 deletions(-)