Skip to content

CVE-2008-0928 security fix

Eduardo Habkost qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4vmdk: check for negative sector nums alsoblock-vmdk.c+1 -12 replies
2/4hw/sd.c: remove ununsed SECTOR_SIZE definehw/sd.c+0 -10 replies
3/4Move SECTOR_BITS/SECTOR_SIZE to block.hblock-vmdk.c block.c block.h+3 -40 replies
4/4Fix CVE-2008-0928 - insufficient block device address range checkingblock-bochs.c block-cloop.c block-cow.c +11 more+110 -342 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/4] CVE-2008-0928 security fix

Hi,

This series is another try to fix CVE-2008-0928 on Qemu, a security vulnerability that is present since a long time. The first 3 patches are simple changes to make the way to the last patch, that is the actual fix.

This fix is similar to the previous fix tat was present on Qemu SVN previously, but changes BlockDriverState to store total_bytes instead of total_sectors. This should avoid problems when byte-based reads are done on some devices, such as on qcow case. The check based on sector range done on the previous fix caused problems for qcow, as documented at:

https://bugzilla.redhat.com/show_bug.cgi?id=485148

The previous fix was reverted almost a year ago but no alternative fix was committed since then. Not having a fix to the vulnerability upstream causes pain to users of the upstream code (who have a vulnerable Qemu) and developers of distributions including Qemu code (who have to carry and forward-port the fix themselves).

Signature · 1 line
Eduardo