Skip to content

OCFS2 locking fixes and lockdep annotations

Jan Kara ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ocfs2: Fix possible deadlock in ocfs2_global_read_dquot()fs/ocfs2/quota_global.c+3 -10 replies
2/7ocfs2: Fix lock inversion in ocfs2_local_read_info()fs/ocfs2/quota_local.c+5 -00 replies
3/7ocfs2: Fix possible deadlock with quotas in ocfs2_setattr()fs/ocfs2/file.c+30 -230 replies
4/7ocfs2: Fix possible deadlock in quota recoveryfs/ocfs2/quota_local.c+9 -70 replies
5/7ocfs2: Correct ordering of ip_alloc_sem and localloc locks for directoriesfs/ocfs2/dir.c+10 -110 replies
6/7vfs: Set special lockdep map for dirs only if not set by fsfs/inode.c+10 -61 reply
6/7vfs: Set special lockdep map for dirs only if not set by fs+0 -01 reply
6/7vfs: Set special lockdep map for dirs only if not set by fsfs/inode.c include/linux/lockdep.h+26 -60 replies
7/7ocfs2: Add lockdep annotationsfs/ocfs2/dlmglue.c fs/ocfs2/dlmglue.h fs/ocfs2/inode.c +4 more+142 -240 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/7] OCFS2 locking fixes and lockdep annotations

Hi,

the first four patches in this series fix locking problems in OCFS2 quota code (three of
them can lead to potential deadlocks). The fifth patch reorders ip_alloc_sem for directories to be acquired before localalloc locks. Mark would you please merge these?
The last two patches implement lockdep annotations for OCFS2 cluster locks. We annotate all
the cluster locks except for special ones like open lock or local quota file lock - these are not held by any particular process and thus lockdep cannot properly track them. I can still hit some lockdep warnings with it (I'll report them separately) but I think the patch is already in a decent state and I don't expect major changes. Please consider merging these lockdep patches.
Happy testing. As always, comments are welcome.

Honza