DMA-API debugging facility v4
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest18 patches 11 repliesIn review
Changes from v3 -> v4 from the cover letter
- a patch from David Woodhouse adds printing of the mapping path stacktrace on an unmap error
- another patch from David added a function which drivers can use to dump their DMA mappings
- two new checks in the sync-path check if the dma memory was mapped for the requested sync direction
- a check for mapping requests of memory on kernel stacks was added (thanks to Arndt Bergmann)
- A bug in the handling of dma_map_sg/dma_unmap_sg pointed out by FUJITA Tomonori was fixed
- As a result of the previous fix a check was added to find if a driver unmaps different count of sg entries than it mapped
- Various changes to the hash (larger hash size, hash function uses lower bits than before)
- Some minor fixes pointed out by reviewers
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/18 | dma-debug: add Kconfig entryarch/ lib/ | +13 | 0 replies | |
| 2/18 | dma-debug: add header file and core data structuresinclude/ lib/ lib/ | +69 | 0 replies | |
| 3/18 | dma-debug: add hash functions for dma_debug_entrieslib/ | +101 | 8 replies | |
| 4/18 | dma-debug: add allocator codelib/ | +57 | 0 replies | |
| 5/18 | dma-debug: add initialization codeinclude/ lib/ | +80 | 0 replies | |
| 6/18 | dma-debug: add kernel command line parametersDocumentation/ lib/ | +48 | 0 replies | |
| 7/18 | dma-debug: add debugfs interfacelib/ | +78 | 1 reply | |
| 8/18 | dma-debug: add core checking functionslib/ | +187 | 0 replies | |
| 9/18 | dma-debug: add checking for map/unmap_page/singleinclude/ lib/ | +76 | 2 replies | |
| 10/18 | dma-debug: add add checking for map/unmap_sginclude/ lib/ | +89 | 0 replies | |
| 11/18 | dma-debug: add checking for [alloc|free]_coherentinclude/ lib/ | +61 | 0 replies | |
| 12/18 | dma-debug: add checks for sync_single_*include/ lib/ | +41 | 0 replies | |
| 13/18 | dma-debug: add checks for sync_single_range_*include/ lib/ | +51 | 0 replies | |
| 14/18 | dma-debug: add checks for sync_single_sg_*include/ lib/ | +52 | 0 replies | |
| 15/18 | dma-debug: add function to dump dma mappingsinclude/ lib/ | +36 | 0 replies | |
| 16/18 | dma-debug: x86 architecture bindingsarch/ arch/ arch/ | +46 | 0 replies | |
| 17/18 | dma-debug: Documentation updateDocumentation/ | +106 | 0 replies | |
| 18/18 | dma-debug: print stacktrace of mapping path on unmap errorlib/ | +38 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/18] DMA-API debugging facility v4
Hi,
this is version 4 of the patchset which introduces code to debug drivers usage of the DMA-API. Many thanks to all the reviewers and the useful comments on the previous versions of this patchset. Appended is a changelog, the shortlog and the diff-stat.
Changes from v3 -> v4:
- a patch from David Woodhouse adds printing of the mapping path stacktrace on an unmap error
- another patch from David added a function which drivers can use to dump their DMA mappings
- two new checks in the sync-path check if the dma memory was mapped for the requested sync direction
- a check for mapping requests of memory on kernel stacks was added (thanks to Arndt Bergmann)
- A bug in the handling of dma_map_sg/dma_unmap_sg pointed out by FUJITA Tomonori was fixed
- As a result of the previous fix a check was added to find if a driver unmaps different count of sg entries than it mapped
- Various changes to the hash (larger hash size, hash function uses lower bits than before)
- Some minor fixes pointed out by reviewers
Changes from v2 -> v3:
- rebased patches against tip/core/iommu branch
- changed storage of virtual address to physical address in struct dma_debug_entry (thanks Fujita)
- removed usage of x86 specific bad_dma_address (thanks Fujita)
- changed a error log message to be more clear (thanks Roel)
- fixed a bug with wrong handling of map_page/unmap_page requests (thanks Michael)
- various improvements and fixes suggested by Ingo, thanks
- added more comments
Changes from v1 -> v2:
- moved code to lib/ and include/linux to make it usable for all architectures
- more fine grained hash locking (locking is now per hash bucket, no global lock anymore)
- dma_debug_entries are preallocated
- per default the code will only print one warning and is silent then
- added a debugfs interface to see some statistics and to enable more verbose error reporting in the kernel log
- added command line parameter to disable debugging code
- allocation errors are now handled correctly
- added documentation about this facility for driver developers
Joerg
Shortlog:
David Woodhouse (2):
dma-debug: add function to dump dma mappings
dma-debug: print stacktrace of mapping path on unmap error
Joerg Roedel (16):
dma-debug: add Kconfig entry
dma-debug: add header file and core data structures
dma-debug: add hash functions for dma_debug_entries
dma-debug: add allocator code
dma-debug: add initialization code
dma-debug: add kernel command line parameters
dma-debug: add debugfs interface
dma-debug: add core checking functions
dma-debug: add checking for map/unmap_page/single
dma-debug: add add checking for map/unmap_sg
dma-debug: add checking for [alloc|free]_coherent
dma-debug: add checks for sync_single_*
dma-debug: add checks for sync_single_range_*
dma-debug: add checks for sync_single_sg_*
dma-debug: x86 architecture bindings
dma-debug: Documentation update
Diffstat:
Documentation/DMA-API.txt | 106 +++++ Documentation/kernel-parameters.txt | 10 + arch/Kconfig | 2 + arch/x86/Kconfig | 1 + arch/x86/include/asm/dma-mapping.h | 45 ++- arch/x86/kernel/pci-dma.c | 6 + include/linux/dma-debug.h | 167 +++++++ lib/Kconfig.debug | 11 + lib/Makefile | 2 + lib/dma-debug.c | 870 +++++++++++++++++++++++++++++++++++ 10 files changed, 1214 insertions(+), 6 deletions(-) create mode 100644 include/linux/dma-debug.h create mode 100644 lib/dma-debug.c