Skip to content

NAND: Multi-chip support for FSL-UPM for TQM8548 modules

Wolfgang Grandegger linux-devicetree linux-mtd linuxppc-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 3 repliesIn review
  2. v34 patches 24 repliesSuperseded
  3. v25 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches8 repliesSuperseded

Changes in v4 from the cover letter

- As Grant suggested, the property "fsl,upm-addr-line-cs-offsets" is now used to define multi-chip support using dedicated address lines for chip selection. This make the properties "num-chips" and "chip-offset" obsolte.

- As Grant suggested, I added the string "tqc,tqm8548-upm-nand" to the list of compatible devices for the TQM8548 modules in case it turns out in the future that the "fsl,upm-addr-line-cs-offsets" method is not generic enough.

- For multi-chip chip devices, the name "mchip" is now used in the code to avoid confusion with the normal NAND "chip".

- Coding style fixes as pointed out by Anton.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4NAND: FSL-UPM: add multi chip supportarch/powerpc/sysdev/fsl_lbc.c drivers/mtd/nand/fsl_upm.c+77 -241 reply
2/4NAND: FSL-UPM: Add wait flags to support board/chip specific delaysdrivers/mtd/nand/fsl_upm.c+18 -21 reply
3/4powerpc: NAND: FSL UPM: document new bindingsDocumentation/powerpc/dts-bindings/fsl/upm-nand.txt+37 -21 reply
4/4powerpc/85xx: TQM8548: Update DTS file for multi-chip supportarch/powerpc/boot/dts/tqm8548-bigflash.dts arch/powerpc/boot/dts/tqm8548.dts+10 -40 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchAnton Vorontsov
1/4A-b
2/4A-b
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] NAND: Multi-chip support for FSL-UPM for TQM8548 modules

This is my forth version of the patch series adding generic support for multi-chip NAND devices to the FSL-UPM driver and support for the Micron MT29F8G08FAB NAND flash memory on the TQM8548 modules. It addresses the issues reported on the mailing list, e.g. the new bindings are now documented as well:

NAND: FSL-UPM: add multi chip support
NAND: FSL-UPM: Add wait flags to support board/chip specific delays
powerpc: NAND: FSL UPM: document new bindings powerpc/85xx: TQM8548: Update DTS file for multi-chip support

Changes since v3:
- As Grant suggested, the property "fsl,upm-addr-line-cs-offsets" is now used to define multi-chip support using dedicated address lines for chip selection. This make the properties "num-chips" and "chip-offset" obsolte.

- As Grant suggested, I added the string "tqc,tqm8548-upm-nand" to the list of compatible devices for the TQM8548 modules in case it turns out in the future that the "fsl,upm-addr-line-cs-offsets" method is not generic enough.

- For multi-chip chip devices, the name "mchip" is now used in the code to avoid confusion with the normal NAND "chip".

- Coding style fixes as pointed out by Anton.

Patch 3 and 4 should go through the powerpc maintainer(s).

Hope this patch series is fine now for inclusion into 2.6.30.

Thanks,

Wolfgang.