Skip to content

swiotlb: changes for powerpc/highmem

Becky Bruce lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 14 repliesIn review
  2. v15 patches 11 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7swiotlb: comment corrections (no code changes)lib/swiotlb.c+11 -130 replies
2/7swiotlb: fix compile warninglib/swiotlb.c+1 -10 replies
3/7swiotlb: map_page fix for highmem systemslib/swiotlb.c+1 -20 replies
4/7swiotlb: Allow arch override of address_needs_mappinglib/swiotlb.c+8 -20 replies
5/7swiotlb: (re)Create swiotlb_unmap_singlelib/swiotlb.c+23 -1313 replies
6/7swiotlb: Use swiotlb_sync_single instead of duplicating codelib/swiotlb.c+12 -180 replies
7/7swiotlb: Change swiotlb_bus_to[phys,virt] prototypesarch/x86/kernel/pci-swiotlb.c include/linux/swiotlb.h lib/swiotlb.c+8 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 0/7] swiotlb: changes for powerpc/highmem

This is v2 of a series of fairly minor patches that get swiotlb working on 32-bit powerpc systems with HIGHMEM, plus some cleanup of the outdated comments in the code. I've made a couple of things weak that ppc needs to override, and have changed the prototypes for a couple of functions to include the hwdev pointer, which we need to ppc to convert bus addresses to and from phys/virt addresses. I've also fixed a build warning I've been seeing on ppc.

In response to commentary on the previous series, I've also refactored the code a bit, altough I did this slightly differently than was suggested because I noticed we could use the new helper function in 2 places instead of one. I've reformatted a bit of code based on commentary as well.

I have not tested this in any way on any non-ppc platforms, so commentary/testing from x86/ia64 folks is, once again, greatly appreciated.

I'm going to be offline for the next week, but will respond to commentary as soon as I return.

Cheers,
Becky

diffstat:

arch/x86/kernel/pci-swiotlb.c |    2 +-
include/linux/swiotlb.h       |    3 +-
lib/swiotlb.c                 |  115 ++++++++++++++++++++++-------------------
3 files changed, 64 insertions(+), 56 deletions(-)