Skip to content

Fix immediate error handling on synthetic aios

Avi Kivity qemu-devel 1 version Applied

Status from this message: Applied all. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2Fix vectored aio bounce handling immediate errorsblock.c+5 -00 replies
2/2Fix DMA API when handling an immediate error from block layerdma-helpers.c+21 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] Fix immediate error handling on synthetic aios

The block layer can signal aio errors in two ways: by calling the completion function with a negative status code, or by returning a NULL aiocb. Two of the synthetic aio implementations (the DMA API and the vectored aio bouncing) fail to handle the second case correctly, resulting in crashes when cancellation of a timed out request is attempted.

I think the long term fix is to have the block layer signal errors in just one way -- by invoking the completion handler with a negative return code -- but in the meanwhile, here are patches that add the required error checking.

Avi Kivity (2):
Fix vectored aio bounce handling immediate errors Fix DMA API when handling an immediate error from block layer

 block.c       |    5 +++++
 dma-helpers.c |   27 +++++++++++++++++++++------
 2 files changed, 26 insertions(+), 6 deletions(-)