tcg: improve logical op support for ppc hosts
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | Add TCG ops for various logical operationstcg/ | +32 | 0 replies | |
| 2/10 | Specialize tcg_gen_not_i64 for 32-bit targetstcg/ | +3 | 1 reply | |
| 3/10 | Implement specialized andc_i{32,64}tcg/ | +11 | 0 replies | |
| 4/10 | Implement specialized eqv_{i32,i64}tcg/ | +11 | 0 replies | |
| 5/10 | Implement specialized nand_i{32,64}tcg/ | +11 | 0 replies | |
| 6/10 | Implement specialized nor_i{32,64}tcg/ | +11 | 0 replies | |
| 7/10 | Implement specialized orc_i{32,64}tcg/ | +11 | 0 replies | |
| 8/10 | Implement new logical instructions for ppctcg/ tcg/ | +31 | 0 replies | |
| 9/10 | Implement new logical instructions for ppc64tcg/ tcg/ | +46 | 0 replies | |
| 10/10 | Remove r0 from the allocation pool on ppc/ppc64tcg/ tcg/ | +0 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Qemu-devel] [PATCH 0/10] tcg: improve logical op support for ppc hosts
This patch series implements the necessary support for native TCG implementations the logical operations andc, orc, eqv, nor, and nand (as opposed to the synthesized implementations currently used by TCG). It also implements backend support for said operations in the ppc and ppc64 backends.
I have tested it sparsely on a ppc64 machine I have access to; Linux user-mode emulation seems to be broken on ppc hosts. I could not run a given binary (something as simple as ls or complicated as gcc) with ppc{,64}-linux-user targeted QEMU. Prior to the guest application crashing, however, I could see in qemu.log that several andc/orc/eqv/nand/nor instructions were being used and being translated correctly.
The patch series also includes one bugfix at the very end, which removes r0 from the allocation pool. The logic of the patch seems straightforward enough to me, but I confess to not being a TCG expert, so if TCG somehow avoids generating instructions with r0 in the "wrong" places, I'd be happy to hear of an explanation why.
-Nathan