Skip to content

ext3 data=guarded

Chris Mason linux-ext4 lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Add block_write_full_page_endio for passing endio handlerfs/buffer.c include/linux/buffer_head.h+37 -110 replies
2/2ext3: add data=guarded modefs/ext3/Makefile fs/ext3/fsync.c fs/ext3/inode.c +10 more+993 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ext3 data=guarded

Hello everyone,

Here is the ext3 data=guarded code again, this time it has passed some basic tests. It should safely leave non data=guarded mounts alone and only be dangerous when the new code is turned on (I hope).

On the performance side, it runs the same as data=writeback, except when you're making files with holes where it runs the same as data=ordered.

There's definitely more CPU time involved with tracking the data=guarded buffer heads and updating i_size when the IO is over, but at least on my 5 drive array that doesn't show up.

For the fsync + background streaming write workload, data=guarded does fsync's in 0.8s, just like data=writeback. data=ordered on the same test was doing between 5 and 30s per fsync, so it seems I've fixed that part at least.

The next step is much more testing (blocksize != pagesize among others) and much more review. But, I'm hoping for some feedback first on if this is a direction we want to take the ext3 code.

The diffstat looks scary, but lots of the changes are comments...

-chris