Fix unsafe disable_irq usage
Status from this message: Applied.
Get series with b4
b4 am [email protected]Versions newest first
8 of 9 patches are in this archive. The cover letter announces 9.
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | ipu_idmac: Use disable_irq_nosync() from within irq handlers.drivers/ | +2 | 0 replies | |
| 2/9 | pxa25x_udc: Use disable_irq_nosync() from within irq handlers.drivers/ | +2 | 0 replies | |
| 3/9 | omap-keypad: Use disable_irq_nosync() from within irq handlers.drivers/ | +10 | 5 replies | |
| 4/9 | sa1111ps2: Use disable_irq_nosync() from within irq handlers.drivers/ | +1 | 0 replies | |
| 5/9 | tsc2007: Use disable_irq_nosync() from within irq handlers.drivers/ | +1 | 0 replies | |
| 6/9 | ucb1400: Use disable_irq_nosync() from within irq handlers.drivers/ | +1 | 0 replies | |
| 8/9 | pcf50633: Use disable_irq_nosync() from within irq handlers.drivers/ | +1 | 0 replies | |
| 9/9 | omap mmc host: Use disable_irq_nosync() from within irq handlers.drivers/ | +1 | 3 replies |
Reviews trailers per patch
1 of 8 patches has a Reviewed-by or Acked-by.
| Patch | Tony Lindgren |
|---|---|
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 8/9 | |
| 9/9 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] Fix unsafe disable_irq usage
After being bitten by unsafe usage of disable_irq from within that irq's handler [1], I went through and used Coccinelle to audit the rest of drivers/ too. This turned up 9 more unsafe usages.
As Haavard pointed out in that thread, disable_irq waits for running handlers of an irq to complete before returning. When a handler disable_irq's its own irq then we see a deadlock.
Note that this wasn't actually observed in the wild until the recent merge of
commit 3aa551c9b4c40018f0e261a178e3d25478dc04a9
Author: Thomas Gleixner <[email protected]> Date: Mon Mar 23 18:28:15 2009 +0100
genirq: add threaded interrupt handler support
Add support for threaded interrupt handlers
Regards,
--Ben.