Skip to content

tracing/workqueue: events support/enhancements, worklets tracing, fixes

Frederic Weisbecker lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19ftrace, workqueuetrace: make workqueue tracepoints use TRACE_EVENT macroinclude/trace/events/workqueue.h include/trace/workqueue.h kernel/trace/trace_workqueue.c +1 more+103 -350 replies
2/19trace_workqueue: use list_for_each_entry() instead of list_for_each_entry_safe()kernel/trace/trace_workqueue.c+4 -60 replies
3/19trace_workqueue: remove cpu_workqueue_stats->first_entrykernel/trace/trace_workqueue.c+0 -40 replies
4/19trace_workqueue: remove blank line between each cpukernel/trace/trace_workqueue.c+0 -70 replies
5/19trace_workqueue: add worklet informationkernel/trace/trace_workqueue.c+175 -440 replies
6/19tracing/workqueue: turn cpu_workqueue_stats::inserted into unsigned intkernel/trace/trace_workqueue.c+5 -50 replies
7/19workqueue_tracepoint: introduce workqueue_handler_exit tracepoint and rename workqueue_execution to workqueue_handler_entryinclude/trace/events/workqueue.h kernel/trace/trace_workqueue.c kernel/workqueue.c+37 -120 replies
8/19workqueue_tracepoint: add workqueue_flush and worklet_cancel tracepointinclude/trace/events/workqueue.h kernel/workqueue.c+40 -00 replies
9/19workqueue_tracepoint: change tracepoint name to fit worklet and workqueue lifecycleinclude/trace/events/workqueue.h kernel/trace/trace_workqueue.c kernel/workqueue.c+16 -170 replies
10/19workqueue_trace: separate worklet_insertion into worklet_enqueue and worklet_enqueue_delayedinclude/trace/events/workqueue.h kernel/trace/trace_workqueue.c kernel/workqueue.c+88 -260 replies
11/19tracing/workqueue: turn workfunc_stats::inserted into unsigned intkernel/trace/trace_workqueue.c+5 -80 replies
12/19tracing/workqueue: avoid accessing task_struct's member variable in stat file readkernel/trace/trace_workqueue.c+25 -250 replies
13/19tracing/workqueue: use list_for_each_entry instead of list_for_each_entry_safe in probe_workqueue_destruction()kernel/trace/trace_workqueue.c+2 -30 replies
14/19tracing/workqueue: add max execution time mesurement for per workletkernel/trace/trace_workqueue.c+70 -130 replies
15/19tracing/workqueue: add execution time average columnkernel/trace/trace_workqueue.c+11 -50 replies
16/19tracing/workqueue: add open/release file handlerskernel/trace/trace_stat.c kernel/trace/trace_stat.h+11 -00 replies
17/19tracing/workqueue: defer workqueue stat release if neededkernel/trace/trace_workqueue.c+72 -130 replies
18/19tracing/workqueue: use the original cpu affinity on probe_workqueue_destructioninclude/trace/events/workqueue.h kernel/trace/trace_workqueue.c kernel/workqueue.c+9 -90 replies
19/19tracing/workqueue: provide documentation for the workqueue tracerDocumentation/trace/workqueue.txt+114 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] tracing/workqueue: events support/enhancements, worklets tracing, fixes

Hi,

This patchset brings various features for the workqueue tracer.

The support of events tracing (tracepoint expanding):
- workqueue_creation
- workqueue_flush
- workqueue_destruction

Also for the worklets:
- worklet_enqueue
- worklet_enqueue_delayed
- worklet_execute
- worklet_complete
- worklet_cancel

Now, most of the lifecycle of worklets and workqueues is available.

The histogram tracing now also supports the worklets. You can measure the max and average execution time of a worklet.

A good bunch of Oleg's comments have been addressed, at least the critical ones (races which can cause freed pointer dereferences, memory leak, etc...). The rest is more about the design itself, such as using the workqueue as the identifier instead of the thread and other things that are in discussion.

Thanks!

Frederic.

The following changes since commit a0e39ed378fb6ba916522764cd508fa7d42ad495:
Heiko Carstens (1):
tracing: fix build failure on s390

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git tracing/workqueue

Frederic Weisbecker (6):
tracing/workqueue: turn cpu_workqueue_stats::inserted into unsigned int tracing/workqueue: add execution time average column tracing/workqueue: add open/release file handlers tracing/workqueue: defer workqueue stat release if needed tracing/workqueue: use the original cpu affinity on probe_workqueue_destruction tracing/workqueue: provide documentation for the workqueue tracer

KOSAKI Motohiro (2):
workqueue_tracepoint: introduce workqueue_handler_exit tracepoint and rename workqueue_execution to workqueue_handler_entry tracing/workqueue: add max execution time mesurement for per worklet

Zhaolei (11):
ftrace, workqueuetrace: make workqueue tracepoints use TRACE_EVENT macro
trace_workqueue: use list_for_each_entry() instead of list_for_each_entry_safe()
trace_workqueue: remove cpu_workqueue_stats->first_entry
trace_workqueue: remove blank line between each cpu
trace_workqueue: add worklet information
workqueue_tracepoint: add workqueue_flush and worklet_cancel tracepoint
workqueue_tracepoint: change tracepoint name to fit worklet and workqueue lifecycle
workqueue_trace: separate worklet_insertion into worklet_enqueue and worklet_enqueue_delayed tracing/workqueue: turn workfunc_stats::inserted into unsigned int
tracing/workqueue: avoid accessing task_struct's member variable in stat file read tracing/workqueue: use list_for_each_entry instead of list_for_each_entry_safe in probe_workqueue_destruction()

 Documentation/trace/workqueue.txt |  114 ++++++++++
 include/trace/events/workqueue.h  |  200 +++++++++++++++++
 include/trace/workqueue.h         |   25 --
 kernel/trace/trace_stat.c         |    8 +
 kernel/trace/trace_stat.h         |    3 +
 kernel/trace/trace_workqueue.c    |  444 +++++++++++++++++++++++++++++--------
 kernel/workqueue.c                |   45 +++--
 7 files changed, 697 insertions(+), 142 deletions(-)
 create mode 100644 Documentation/trace/workqueue.txt
 create mode 100644 include/trace/events/workqueue.h
 delete mode 100644 include/trace/workqueue.h