Skip to content

igb: drop stats due to OS cannot keep up

Jesper Dangaard Brouer netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2igb: Implement reading of reg RQDPC (Receive Queue Drop Packet Count)drivers/net/igb/e1000_regs.h drivers/net/igb/igb.h drivers/net/igb/igb_ethtool.c +1 more+36 -96 replies
2/2igb: Record host memory receive overflow in net_statsdrivers/net/igb/igb_main.c+9 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] igb: drop stats due to OS cannot keep up

The following patchset address "drop" stats counters in the igb driver (chips 82576 and 82575). The drop stats addressed here are due to the OS cannot keep up.

I have only tested it for the 82576 chip, as my (12 port) 82575 chip based NIC from Hotlava Systems recently died in my testlab :-(((

[First patch]
Implements reading of the per queue drop stats.
These stats only gets incremented if the DROP_EN bit it set (in the SRRCTL register for that queue, or QDE reg is set).

[Second patch]
Address the case where the DROP_EN it NOT set. In
this case a global register records the equivalent drop type. And aggregation of these two types of drops into the device net_stats.

I strongly believe that these drops counters should be made available to sysadm's through the normal device stats. These stats are essential when diagnosing server performance issues, as these stats are due to the OS cannot keep up. I strongly believe that it should be stored in the net_stats rx_fifo_errors counter, to indicate performance issues.

Signature · 7 lines
Med venlig hilsen / Best regards
  Jesper Brouer
  ComX Networks A/S
  Linux Network developer
  Cand. Scient Datalog / MSc.
  Author of http://adsl-optimizer.dk
  LinkedIn: http://www.linkedin.com/in/brouer