Skip to content

ide-atapi: remove pc->buf and misc cleanups

Borislav Petkov linux-ide lkml 2 versions – Applied

Status from this message: applied

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 8 repliesApplied
  2. v114 patches 13 repliesSuperseded

Changelog from the cover letter

- v1:

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/15ide-tape: fix potential fs requests bugdrivers/ide/ide-tape.c+1 -10 replies
2/15ide-atapi: switch to blk_rq_bytes() on do_request() pathdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c+18 -160 replies
3/15ide-atapi: switch to rq->resid_lendrivers/ide/ide-atapi.c drivers/ide/ide-tape.c include/linux/ide.h+13 -200 replies
4/15ide-atapi: add a len-parameter to ide_queue_pc_taildrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-floppy_ioctl.c +2 more+27 -260 replies
5/15ide-atapi: add a buffer-arg to ide_queue_pc_taildrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-floppy_ioctl.c +2 more+41 -430 replies
6/15ide-floppy/ide_floppy_get_flexible_disk_page: use local bufferdrivers/ide/ide-floppy.c+10 -100 replies
7/15ide-floppy/ide_floppy_get_sfrp_bit: use local bufferdrivers/ide/ide-floppy_ioctl.c+3 -20 replies
8/15ide-floppy/ide_floppy_format_unit: use local bufferdrivers/ide/ide-floppy_ioctl.c+13 -110 replies
9/15ide-atapi: use local sense bufferdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c+8 -40 replies
10/15ide-floppy/ide_floppy_get_format_progress: use local sense bufferdrivers/ide/ide-floppy_ioctl.c+2 -10 replies
11/15ide-tape/ide_tape_get_bsize_from_bdesc: use local bufferdrivers/ide/ide-tape.c+6 -50 replies
12/15ide-tape: fix READ POSITION cmd handlingdrivers/ide/ide-tape.c+49 -530 replies
13/15ide-atapi: remove pc->bufdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-floppy_ioctl.c +2 more+3 -300 replies
14/15ide-cd: use whole request_sense buffer in EHdrivers/ide/ide-cd.c+10 -110 replies
15/15ide: unify interrupt reason checkingdrivers/ide/ide-atapi.c drivers/ide/ide-cd.c include/linux/ide.h+71 -730 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH 0/15 v2] ide-atapi: remove pc->buf and misc cleanups

Hi,

this is the newest respin of the current patchset with all issues from the previous review round fixed:

- 0003: fixed checkpatch issues

- 0005: documented additional change in the commit message

- 0009: converted to using bio_data() helper; pushed pc->buf removal to #12; moved unrelated changes to 0010

- 0014: updated/fixed checkpatch issues

It also got rebased ontop of block/for-2.6.31 after Tejun's stuff got merged.

Changelog:
- v1:

Among the changes is a first attempt to remove the 64 byte buffer embedded in each packet command sent to an ide drive. Also, some ireason handling unification is there along with other minor stuff.

This is based ontop of

git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-2.6-block.git for-2.6.31

and is at

git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git remove-pc-buf

 drivers/ide/ide-atapi.c        |  138 ++++++++++++++++++++------------
 drivers/ide/ide-cd.c           |   68 +++-------------
 drivers/ide/ide-floppy.c       |   50 +++++-------
 drivers/ide/ide-floppy_ioctl.c |   43 ++++++-----
 drivers/ide/ide-tape.c         |  172 +++++++++++++++++++---------------------
 include/linux/ide.h            |   18 +---
 6 files changed, 229 insertions(+), 260 deletions(-)

--
Thanks,
Boris.