Skip to content

RFC orinoco: initiate conversion to cfg80211

David Kilroy linux-wireless 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest23 patches 4 repliesIn review
  2. v1 RFC3 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23cfg80211: add wrapper function to get wiphy from priv pointerinclude/net/cfg80211.h+11 -00 replies
2/23cfg80211: Advertise ciphers via WE according to driver capabilitynet/wireless/wext-compat.c+10 -21 reply
3/23cfg80211: allow drivers that can't scan for specific ssidsnet/wireless/core.c net/wireless/wext-compat.c+2 -40 replies
4/23cfg80211: set WE encoding size based on available ciphersnet/wireless/wext-compat.c+6 -32 replies
5/23cfg80211: infer WPA and WPA2 support from TKIP and CCMPnet/wireless/wext-compat.c+4 -41 reply
6/23orinoco: Move firmware capability determination into hw.cdrivers/net/wireless/orinoco/hw.c drivers/net/wireless/orinoco/hw.h drivers/net/wireless/orinoco/main.c+219 -2160 replies
7/23orinoco: Move card reading code into hw.cdrivers/net/wireless/orinoco/hw.c drivers/net/wireless/orinoco/hw.h drivers/net/wireless/orinoco/main.c+115 -1000 replies
8/23orinoco: Move FID allocation to hw.cdrivers/net/wireless/orinoco/hw.c drivers/net/wireless/orinoco/hw.h drivers/net/wireless/orinoco/main.c+26 -230 replies
9/23orinoco: use dev_err in early initialisation routinesdrivers/net/wireless/orinoco/hw.c+42 -500 replies
10/23orinoco: firmware helpers should use dev_err and friendsdrivers/net/wireless/orinoco/fw.c+17 -240 replies
11/23orinoco: Replace net_device with orinoco_private in driver interfacesdrivers/net/wireless/orinoco/airport.c drivers/net/wireless/orinoco/main.c drivers/net/wireless/orinoco/orinoco.h +7 more+132 -1390 replies
12/23orinoco: initialise independently of netdevdrivers/net/wireless/orinoco/airport.c drivers/net/wireless/orinoco/main.c drivers/net/wireless/orinoco/orinoco.h +6 more+63 -240 replies
13/23orinoco: Change set_tkip to use orinoco_private instead of hermes_tdrivers/net/wireless/orinoco/hw.c drivers/net/wireless/orinoco/hw.h drivers/net/wireless/orinoco/wext.c+6 -60 replies
14/23orinoco: initiate cfg80211 conversiondrivers/net/wireless/orinoco/Kconfig drivers/net/wireless/orinoco/Makefile drivers/net/wireless/orinoco/cfg.c +4 more+256 -890 replies
15/23orinoco: make firmware download less verbosedrivers/net/wireless/orinoco/hermes_dld.c+23 -270 replies
16/23orinoco: move netdev interface creation to main driverdrivers/net/wireless/orinoco/airport.c drivers/net/wireless/orinoco/main.c drivers/net/wireless/orinoco/orinoco.h +6 more+116 -1160 replies
17/23airport: store irq in card private structuredrivers/net/wireless/orinoco/airport.c+12 -120 replies
18/23orinoco: Handle suspend/restore in core driverdrivers/net/wireless/orinoco/airport.c drivers/net/wireless/orinoco/main.c drivers/net/wireless/orinoco/orinoco.h +3 more+70 -1610 replies
19/23orinoco: provide generic commit functiondrivers/net/wireless/orinoco/hw.c drivers/net/wireless/orinoco/hw.h drivers/net/wireless/orinoco/main.c +2 more+294 -2690 replies
20/23orinoco: convert mode setting to cfg80211drivers/net/wireless/orinoco/cfg.c drivers/net/wireless/orinoco/hw.c drivers/net/wireless/orinoco/main.c +2 more+77 -800 replies
21/23orinoco: convert scanning to cfg80211drivers/net/wireless/orinoco/cfg.c drivers/net/wireless/orinoco/hermes.h drivers/net/wireless/orinoco/hw.c +6 more+357 -7460 replies
22/23orinoco: convert giwrange to cfg80211drivers/net/wireless/orinoco/wext.c+1 -1140 replies
23/23orinoco: remove WE nickname supportdrivers/net/wireless/orinoco/wext.c+0 -430 replies

Reviews trailers per patch

1 of 23 patches has a Reviewed-by or Acked-by.

PatchJohannes Berg
1/23
2/23
3/23
4/23
5/23A-b
6/23
7/23
8/23
9/23
10/23
11/23
12/23
13/23
14/23
15/23
16/23
17/23
18/23
19/23
20/23
21/23
22/23
23/23

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFC v2 00/23] orinoco: initiate conversion to cfg80211

I've completely refactorred since the last RFC, and switched to the cfg80211 handlers for scanning, mode changing and giwrange.

Patches 1-5 modify cfg80211, mostly so it can advertise (the more restrictive) orinoco capabilities correctly.

Patches 6-13 refactor the orinoco internal interfaces and initialisation to make the switch to cfg80211 easier. The main thrust is to avoid using net_device in the device drivers allowing us to register the net_device later.

Patch 14 starts the cfg80211 conversion, before patches 15-19 cleanup the fallout from the conversion.

Patches 20 though 23 convert a few of the WE handler to cfg80211 handlers.

The refactorring affects all the card and firmware types, but I'm only able to test orinoco_cs with Agere firmware.
---
David Kilroy (23):
cfg80211: add wrapper function to get wiphy from priv pointer
cfg80211: Advertise ciphers via WE according to driver capability
cfg80211: allow drivers that can't scan for specific ssids
cfg80211: set WE encoding size based on available ciphers
cfg80211: infer WPA and WPA2 support from TKIP and CCMP
orinoco: Move firmware capability determination into hw.c
orinoco: Move card reading code into hw.c
orinoco: Move FID allocation to hw.c
orinoco: use dev_err in early initialisation routines
orinoco: firmware helpers should use dev_err and friends
orinoco: Replace net_device with orinoco_private in driver interfaces
orinoco: initialise independently of netdev
orinoco: Change set_tkip to use orinoco_private instead of hermes_t
orinoco: initiate cfg80211 conversion
orinoco: make firmware download less verbose
orinoco: move netdev interface creation to main driver
airport: store irq in card private structure
orinoco: Handle suspend/restore in core driver
orinoco: provide generic commit function
orinoco: convert mode setting to cfg80211
orinoco: convert scanning to cfg80211
orinoco: convert giwrange to cfg80211
orinoco: remove WE nickname support

 drivers/net/wireless/orinoco/Kconfig          |    1 +
 drivers/net/wireless/orinoco/Makefile         |    2 +-
 drivers/net/wireless/orinoco/airport.c        |   98 +--
 drivers/net/wireless/orinoco/cfg.c            |  169 ++++
 drivers/net/wireless/orinoco/cfg.h            |   15 +
 drivers/net/wireless/orinoco/fw.c             |   41 +-
 drivers/net/wireless/orinoco/hermes.h         |    2 +-
 drivers/net/wireless/orinoco/hermes_dld.c     |   50 +-
 drivers/net/wireless/orinoco/hw.c             |  668 +++++++++++++++-
 drivers/net/wireless/orinoco/hw.h             |   11 +-
 drivers/net/wireless/orinoco/main.c           | 1131 +++++++++----------------
 drivers/net/wireless/orinoco/main.h           |    3 +-
 drivers/net/wireless/orinoco/orinoco.h        |   49 +-
 drivers/net/wireless/orinoco/orinoco_cs.c     |   96 +--
 drivers/net/wireless/orinoco/orinoco_nortel.c |   38 +-
 drivers/net/wireless/orinoco/orinoco_pci.c    |   38 +-
 drivers/net/wireless/orinoco/orinoco_pci.h    |   57 +--
 drivers/net/wireless/orinoco/orinoco_plx.c    |   38 +-
 drivers/net/wireless/orinoco/orinoco_tmd.c    |   38 +-
 drivers/net/wireless/orinoco/scan.c           |  265 +++----
 drivers/net/wireless/orinoco/scan.h           |   21 +-
 drivers/net/wireless/orinoco/spectrum_cs.c    |   96 +--
 drivers/net/wireless/orinoco/wext.c           |  878 ++------------------
 include/net/cfg80211.h                        |   11 +
 net/wireless/core.c                           |    3 -
 net/wireless/wext-compat.c                    |   24 +-
 26 files changed, 1725 insertions(+), 2118 deletions(-)
 create mode 100644 drivers/net/wireless/orinoco/cfg.c
 create mode 100644 drivers/net/wireless/orinoco/cfg.h